Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is '--no-deps --no-build-isolation' needed for Python given conda-build defaults? #583

Closed
matthewfeickert opened this issue Nov 16, 2024 · 1 comment

Comments

@matthewfeickert
Copy link

In PR #480 the use of --no-deps --no-build-isolation was introduced as defaults for Python pip installs

] = "<{ PYTHON }} -m pip install . -vv --no-deps --no-build-isolation"

(now at

"<{ PYTHON }} -m pip install . -vv --no-deps --no-build-isolation"

)

However, as @henryiii points out in conda-forge/packaging-feedstock#32 (comment), conda-build already sets these defaults

...
    env["PIP_NO_BUILD_ISOLATION"] = "False"
    # some other env vars to have pip ignore dependencies.
    # we supply them ourselves instead.
    env["PIP_NO_DEPENDENCIES"] = True
    env["PIP_IGNORE_INSTALLED"] = True
...

Is there any reason to have these (good options for conda package builds) duplicated here so that they appear explicitly in conda package repiece meta.yaml files?

@matthewfeickert
Copy link
Author

Got beaten out by Henry as he opened Issue #582 just ahead of me, so closing as duplicate of that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant