Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] grayskull fails to recognise poetry entrypoints? #477

Closed
dhirschfeld opened this issue Jul 28, 2023 · 2 comments · Fixed by #489
Closed

[BUG] grayskull fails to recognise poetry entrypoints? #477

dhirschfeld opened this issue Jul 28, 2023 · 2 comments · Fixed by #489
Assignees
Labels
bug Something isn't working

Comments

@dhirschfeld
Copy link

Describe the bug

No entry point is defined for py2puml even though it is specified in the pyproject.toml

[tool.poetry.scripts]
py2puml = 'py2puml.cli:run

To Reproduce

grayskull pypi py2puml

Expected behavior

The recipe should have a py2puml entry point defined:

build:
  noarch: python
  script: {{ PYTHON }} -m pip install . -vv
  number: 0
  entry_points:
    - py2puml = py2puml.cli:run

Outputs

Actual result:

{% set name = "py2puml" %}
{% set version = "0.7.2" %}

package:
  name: {{ name|lower }}
  version: {{ version }}

source:
  url: https://pypi.io/packages/source/{{ name[0] }}/{{ name }}/py2puml-{{ version }}.tar.gz
  sha256: d655c5a5267677225d225297abde6df883d87551cb853426a502e2d4143609b3

build:
  noarch: python
  script: {{ PYTHON }} -m pip install . -vv
  number: 0

requirements:
  host:
    - python >=3.8,<4.0
    - poetry >=0.12
    - poetry-core
    - pip
  run:
    - python >=3.8.0,<4.0.0

test:
  imports:
    - py2puml
  commands:
    - pip check
  requires:
    - pip

about:
  home: https://github.com/lucsorel/py2puml
  summary: Generate PlantUML class diagrams to document your Python application.
  license: MIT
  license_file: LICENSE

extra:
  recipe-maintainers:
    - dhirschfeld

Environment:

❯ grayskull --version
2.3.0
@dhirschfeld dhirschfeld added the bug Something isn't working label Jul 28, 2023
@marcelotrevisani marcelotrevisani self-assigned this Sep 14, 2023
@marcelotrevisani
Copy link
Member

marcelotrevisani commented Sep 14, 2023

that is indeed missing, I am going to put this on my backlog

@marcelotrevisani marcelotrevisani linked a pull request Sep 20, 2023 that will close this issue
@marcelotrevisani
Copy link
Member

It is fixed with #489

it generated the following recipe:

{% set name = "py2puml" %}
{% set version = "0.8.0" %}

package:
  name: {{ name|lower }}
  version: {{ version }}

source:
  url: https://pypi.io/packages/source/{{ name[0] }}/{{ name }}/py2puml-{{ version }}.tar.gz
  sha256: a6d126e9d964be9375f7837430b3f56320c5a33e067082d2a0b4fc071b710103

build:
  entry_points:
    - py2puml = py2puml.cli:run
  noarch: python
  script: {{ PYTHON }} -m pip install . -vv --no-deps --no-build-isolation
  number: 0

requirements:
  host:
    - python >=3.8,<4.0
    - poetry-core
    - pip
  run:
    - python >=3.8.0,<4.0.0

test:
  imports:
    - py2puml
  commands:
    - pip check
    - py2puml --help
  requires:
    - pip

about:
  home: https://github.com/lucsorel/py2puml
  summary: Generate PlantUML class diagrams to document your Python application.
  license: MIT
  license_file: LICENSE

extra:
  recipe-maintainers:
    - marcelotrevisani

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants