Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Grayskull inexplicably deletes the user's entire terminal scrollback when run #420

Closed
CAM-Gerlach opened this issue Nov 22, 2022 · 0 comments · Fixed by #497
Closed
Labels
bug Something isn't working

Comments

@CAM-Gerlach
Copy link

Describe the bug

When I ran Grayskull for the first time to convert a PyPI package (sphinx-lint) just now, as soon as it was executed, it inexplicably deleted the entire scrollback of my terminal—even the prompt at which I entered the greyskull command. Naturally, it was rather frustrating and upsetting to me as a user that tens of thousands of lines of output, accumulated over several days of work and which I at times need to go back and reference, were inexplicably wiped out in an instant. I can't think of any plausible reason for a straightforward package conversion tool to perform such a destructive action with no conceivable connection to its purpose on unrelated user data, and I'm not aware of any other tool that deliberately does this, so I can only assume this is a bug.

To Reproduce
Steps to reproduce the behavior:

  1. Install Grayskull in a clean environment with conda install -c conda-forge grayskull
  2. Open a new terminal
  3. Enter any command, e.g. echo test
  4. Execute Grayskull, e.g. greyskull pypi pytest
  5. User's terminal scrollback is deleted

Expected behavior
A clear and concise description of what you expected to happen.

Grayskull doesn't delete the terminal's entire scrollback history, and instead just emits its output like any other CLI tool.

Outputs
If applicable, add the output to help explain your problem.

Example screenshot

image

Environment:

`conda list`
# packages in environment at C:\Miniconda3\envs\tools:
#
# Name                    Version                   Build  Channel
alabaster                 0.7.12                     py_0    conda-forge
babel                     2.10.3             pyhd8ed1ab_0    conda-forge
blurb                     1.1.0                    pypi_0    pypi
brotlipy                  0.7.0           py39hb82d6ee_1004    conda-forge
build                     0.7.0              pyhd8ed1ab_0    conda-forge
bzip2                     1.0.8                h8ffe710_4    conda-forge
ca-certificates           2022.9.24            h5b45459_0    conda-forge
certifi                   2022.9.24          pyhd8ed1ab_0    conda-forge
cffi                      1.15.1           py39h0878f49_0    conda-forge
charset-normalizer        2.1.1              pyhd8ed1ab_0    conda-forge
cherry-picker             2.1.0                    pypi_0    pypi
click                     8.1.3            py39hcbf5309_0    conda-forge
colorama                  0.4.5              pyhd8ed1ab_0    conda-forge
conda-souschef            2.2.3              pyhd8ed1ab_0    conda-forge
cryptography              38.0.2           py39h58e9bdb_0    conda-forge
docutils                  0.16             py39hcbf5309_3    conda-forge
gidgethub                 5.2.1              pyhd8ed1ab_0    conda-forge
git                       2.38.1               h57928b3_1    conda-forge
grayskull                 1.8.4              pyhd8ed1ab_0    conda-forge
idna                      3.4                pyhd8ed1ab_0    conda-forge
imagesize                 1.4.1              pyhd8ed1ab_0    conda-forge
importlib-metadata        4.11.4           py39hcbf5309_0    conda-forge
intel-openmp              2022.1.0          h57928b3_3787    conda-forge
jinja2                    3.1.2              pyhd8ed1ab_1    conda-forge
libblas                   3.9.0              16_win64_mkl    conda-forge
libcblas                  3.9.0              16_win64_mkl    conda-forge
libffi                    3.4.2                h8ffe710_5    conda-forge
liblapack                 3.9.0              16_win64_mkl    conda-forge
libsqlite                 3.39.4               hcfcfb64_0    conda-forge
libzlib                   1.2.13               hcfcfb64_4    conda-forge
markupsafe                2.1.1            py39hb82d6ee_1    conda-forge
mkl                       2022.1.0           h6a75c08_874    conda-forge
numpy                     1.23.5           py39hbccbffa_0    conda-forge
openssl                   1.1.1s               hcfcfb64_0    conda-forge
packaging                 21.3               pyhd8ed1ab_0    conda-forge
pep517                    0.12.0             pyhd8ed1ab_3    conda-forge
pip                       22.3               pyhd8ed1ab_0    conda-forge
pkginfo                   1.8.3              pyhd8ed1ab_0    conda-forge
progressbar2              4.2.0              pyhd8ed1ab_0    conda-forge
pycparser                 2.21               pyhd8ed1ab_0    conda-forge
pygments                  2.13.0             pyhd8ed1ab_0    conda-forge
pyjwt                     2.5.0              pyhd8ed1ab_0    conda-forge
pyopenssl                 22.1.0             pyhd8ed1ab_0    conda-forge
pyparsing                 3.0.9              pyhd8ed1ab_0    conda-forge
pysocks                   1.7.1            py39hcbf5309_5    conda-forge
python                    3.9.13          h9a09f29_0_cpython    conda-forge
python-docs-theme         2022.1                   pypi_0    pypi
python-utils              3.4.5              pyhd8ed1ab_0    conda-forge
python_abi                3.9                      2_cp39    conda-forge
pytz                      2022.4             pyhd8ed1ab_0    conda-forge
rapidfuzz                 2.13.2           py39h99910a6_0    conda-forge
regex                     2022.9.13        py39ha55989b_0    conda-forge
requests                  2.28.1             pyhd8ed1ab_1    conda-forge
ruamel.yaml               0.17.21          py39ha55989b_2    conda-forge
ruamel.yaml.clib          0.2.7            py39ha55989b_0    conda-forge
ruamel.yaml.jinja2        0.2.4                      py_1    conda-forge
setuptools                65.5.0             pyhd8ed1ab_0    conda-forge
snowballstemmer           2.2.0              pyhd8ed1ab_0    conda-forge
sphinx                    4.5.0              pyh6c4a22f_0    conda-forge
sphinx-lint               0.6.5                    pypi_0    pypi
sphinxcontrib-applehelp   1.0.2                      py_0    conda-forge
sphinxcontrib-devhelp     1.0.2                      py_0    conda-forge
sphinxcontrib-htmlhelp    2.0.0              pyhd8ed1ab_0    conda-forge
sphinxcontrib-jsmath      1.0.1                      py_0    conda-forge
sphinxcontrib-qthelp      1.0.3                      py_0    conda-forge
sphinxcontrib-serializinghtml 1.1.5              pyhd8ed1ab_2    conda-forge
sqlite                    3.39.4               hcfcfb64_0    conda-forge
stdlib-list               0.8.0              pyhd8ed1ab_0    conda-forge
tbb                       2021.7.0             h91493d7_0    conda-forge
tk                        8.6.12               h8ffe710_0    conda-forge
tomli                     2.0.1              pyhd8ed1ab_0    conda-forge
tomli-w                   1.0.0              pyhd8ed1ab_0    conda-forge
types-cryptography        3.3.23.1                 pypi_0    pypi
tzdata                    2022e                h191b570_0    conda-forge
ucrt                      10.0.20348.0         h57928b3_0    conda-forge
uritemplate               4.1.1              pyhd8ed1ab_0    conda-forge
urllib3                   1.26.11            pyhd8ed1ab_0    conda-forge
vc                        14.2                 hac3ee0b_8    conda-forge
vs2015_runtime            14.29.30139          h890b9b1_8    conda-forge
wheel                     0.37.1             pyhd8ed1ab_0    conda-forge
win_inet_pton             1.1.0            py39hcbf5309_4    conda-forge
xz                        5.2.6                h8d14728_0    conda-forge
zipp                      3.9.0              pyhd8ed1ab_0    conda-forge
`pip list`
Package                       Version   Editable project location
----------------------------- --------- ------------------------------------------------------------
alabaster                     0.7.12
Babel                         2.10.3
blurb                         1.1.0
brotlipy                      0.7.0
build                         0.7.0
certifi                       2022.9.24
cffi                          1.15.1
charset-normalizer            2.1.1
cherry_picker                 2.1.0     C:\Users\C. A. M. Gerlach\Documents\dev\Python\cherry-picker
click                         8.1.3
colorama                      0.4.5
conda-souschef                2.2.3
cryptography                  38.0.2
docutils                      0.16
gidgethub                     5.2.1
grayskull                     1.8.4
idna                          3.4
imagesize                     1.4.1
importlib-metadata            4.11.4
Jinja2                        3.1.2
MarkupSafe                    2.1.1
numpy                         1.23.5
packaging                     21.3
pep517                        0.12.0
pip                           22.3
pkginfo                       1.8.3
progressbar2                  4.2.0
pycparser                     2.21
Pygments                      2.13.0
PyJWT                         2.5.0
pyOpenSSL                     22.1.0
pyparsing                     3.0.9
PySocks                       1.7.1
python-docs-theme             2022.1
python-utils                  3.4.5
pytz                          2022.4
rapidfuzz                     2.13.2
regex                         2022.9.13
requests                      2.28.1
ruamel.yaml                   0.17.21
ruamel.yaml.clib              0.2.7
ruamel.yaml.jinja2            0.2.4
setuptools                    65.5.0
snowballstemmer               2.2.0
Sphinx                        4.5.0
sphinx-lint                   0.6.5
sphinxcontrib-applehelp       1.0.2
sphinxcontrib-devhelp         1.0.2
sphinxcontrib-htmlhelp        2.0.0
sphinxcontrib-jsmath          1.0.1
sphinxcontrib-qthelp          1.0.3
sphinxcontrib-serializinghtml 1.1.5
stdlib-list                   0.8.0
tomli                         2.0.1
tomli_w                       1.0.0
types-cryptography            3.3.23.1
uritemplate                   4.1.1
urllib3                       1.26.11
wheel                         0.37.1
win-inet-pton                 1.1.0
zipp                          3.9.0

grayskull --version

1.8.4

Additional context
Add any other context about the problem here.

This occurred on Windows using both Git Bash and cmd.exe, and both using ConEmu and the default Windows terminal emulator, so it does not appear to be anything isolated to my setup, though it is surprising that I couldn't find any other issues about it.

@CAM-Gerlach CAM-Gerlach added the bug Something isn't working label Nov 22, 2022
@marcelotrevisani marcelotrevisani linked a pull request Sep 21, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant