Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convert fails conda-smithy linter #280

Open
lucascolley opened this issue Dec 31, 2024 · 2 comments
Open

convert fails conda-smithy linter #280

lucascolley opened this issue Dec 31, 2024 · 2 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@lucascolley
Copy link

lucascolley commented Dec 31, 2024

What happened?
The following diff was needed to pass the conda-smithy linter after using convert:

diff --git a/recipe/recipe.yaml b/recipe/recipe.yaml
index 372e4c3..26fe8d2 100644
--- a/recipe/recipe.yaml
+++ b/recipe/recipe.yaml
@@ -1,5 +1,3 @@
-schema_version: 1
-
 context:
   name: array-api-extra
   version: 0.4.0
@@ -56,4 +54,3 @@ about:
 extra:
   recipe-maintainers:
     - lucascolley
-

To Reproduce

Steps to reproduce the behavior:

Additional Details (please complete the following information):
version 0.4.0

@lucascolley lucascolley added bug Something isn't working to sort Needs additional investigation labels Dec 31, 2024
@schuylermartin45
Copy link
Collaborator

schema_version is a required field for all V1 recipe files. It is a future-proofing component of the spec. If this linter is having an issue with that, it is a problem with the linter and not Conda Recipe Manager.

As for the trailing whitespace, I don't think this is the fault of the CRM project. In other words, CRM did nothing wrong, this is a tabs-vs-spaces-esk styling debate. We are not beholden to the preferences of conda-forge, we aim to provide tooling that can be used by the conda community as a whole. In other repositories, this is the norm.

We could add a flag to control the trailing whitespace. Honestly if this is being run in an automated environment, I would just run a sed/tr command to handle that. I'll leave this ticket open for discussion on that point.

@schuylermartin45 schuylermartin45 added good first issue Good for newcomers and removed to sort Needs additional investigation labels Jan 2, 2025
@lucascolley
Copy link
Author

thanks, opened conda-forge/conda-smithy#2201

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
Status: Blocked
Development

No branches or pull requests

2 participants