Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always setting the ABI tag to <python tag>m is incorrect #70

Open
ender-wieczorek opened this issue Oct 25, 2021 · 1 comment
Open

Always setting the ABI tag to <python tag>m is incorrect #70

ender-wieczorek opened this issue Oct 25, 2021 · 1 comment

Comments

@ender-wieczorek
Copy link

We always set the ABI tag to m:

atag = self.python_tag + 'm'
This doesn't seem correct.

The default installation of conda:

$ wget --quiet \
>     https://repo.anaconda.com/miniconda/Miniconda3-py38_4.10.3-Linux-x86_64.sh \
>     --output-document Miniconda.sh && \
>     bash Miniconda.sh -b -p ~/miniconda && \
>     rm Miniconda.sh
$ source ~/miniconda/bin/activate

has a Python version with cpython-38-x86_64-linux-gnu ABI:

$ python
>>> import sysconfig
>>> sysconfig.get_config_var('SOABI')
'cpython-38-x86_64-linux-gnu'

All the packages also have that ABI:

$ cd ~/miniconda/lib/python3.8/
$ find . -name *.so
./site-packages/ruamel_yaml/ext/_ruamel_yaml.cpython-38-x86_64-linux-gnu.so
...

So we're putting *.so built for cpython-38 in a wheel which states it's compatible with cp38m.

@YaroslavKormushyn
Copy link

There's a PR for this #55 which has been sitting there for quite some time (the original builds are not even online anymore in Azure DevOps).
I'm fairly new to python and conda, so I don't really know how to fix the failing tests in that PR, but you're welcome to contribute! I'm sure it will fix your problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants