You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In PR ( conda-forge/conda-smithy#1122 ), conda-smithy added support for linting shell scripts with shellcheck. This would help catch issues in shell scripts in recipes.
The dependency on shellcheck was added in PR ( #184 ) as part of the 3.6.13 release. It remained around for a few releases. Then ~1 month laters was removed in PR ( #188 ). Unfortunately there doesn't seem to be much context about why it needed to be removed.
Recently we discussed adding it back in this thread ( #246 (comment) ). However we were not able to figure out why it was removed or what would be needed to add it back.
Would be good to get more context on what the issues were here and retry adding it.
The text was updated successfully, but these errors were encountered:
One issue with making shellcheck a hard dependency is there is no ppc64le package. PR ( conda-forge/shellcheck-feedstock#13 ) attempts to add this, but there is much more work needed there
That dev workflow also doesn't run on ppc64le, but if there are other reasons not to include the otherwise-generally-excellent shellcheck, it would make for good discussion
In PR ( conda-forge/conda-smithy#1122 ),
conda-smithy
added support for linting shell scripts withshellcheck
. This would help catch issues in shell scripts in recipes.The dependency on
shellcheck
was added in PR ( #184 ) as part of the3.6.13
release. It remained around for a few releases. Then ~1 month laters was removed in PR ( #188 ). Unfortunately there doesn't seem to be much context about why it needed to be removed.Recently we discussed adding it back in this thread ( #246 (comment) ). However we were not able to figure out why it was removed or what would be needed to add it back.
Would be good to get more context on what the issues were here and retry adding it.
The text was updated successfully, but these errors were encountered: