Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing shellcheck dependency #248

Open
jakirkham opened this issue Feb 23, 2023 · 3 comments
Open

Missing shellcheck dependency #248

jakirkham opened this issue Feb 23, 2023 · 3 comments

Comments

@jakirkham
Copy link
Member

In PR ( conda-forge/conda-smithy#1122 ), conda-smithy added support for linting shell scripts with shellcheck. This would help catch issues in shell scripts in recipes.

The dependency on shellcheck was added in PR ( #184 ) as part of the 3.6.13 release. It remained around for a few releases. Then ~1 month laters was removed in PR ( #188 ). Unfortunately there doesn't seem to be much context about why it needed to be removed.

Recently we discussed adding it back in this thread ( #246 (comment) ). However we were not able to figure out why it was removed or what would be needed to add it back.

Would be good to get more context on what the issues were here and retry adding it.

@jakirkham
Copy link
Member Author

One issue with making shellcheck a hard dependency is there is no ppc64le package. PR ( conda-forge/shellcheck-feedstock#13 ) attempts to add this, but there is much more work needed there

@bollwyvl
Copy link

Any thoughts appreciated here: conda-forge/staged-recipes#28374

That dev workflow also doesn't run on ppc64le, but if there are other reasons not to include the otherwise-generally-excellent shellcheck, it would make for good discussion

@jakirkham
Copy link
Member Author

FWIW we did add shellcheck in the linter webservice. So that should already work (if a feedstock or recipe enables it)

xref: conda-forge/conda-forge-webservices#546

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants