Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow ECR access without aws_access_key_id and aws_secret_access_key #94

Closed
william-tran opened this issue Feb 6, 2020 · 2 comments
Closed

Comments

@william-tran
Copy link

william-tran commented Feb 6, 2020

I've been trying out the ECR features that were just added, thanks! Our workers already have an assumed role, so they don't need to auth using an access key. PR coming shortly

@analytically
Copy link

@vito

@vito
Copy link
Member

vito commented Jun 25, 2020

Per #98 (comment), this is not a change we can make to the resource type.

The latest activity on this problem area is here: concourse/concourse#3023 (comment) - we need Prototypes implemented, and Prototype-based var sources in order to provide worker role-based auth without breaking the resource model. The Prototypes RFC is expected to be merged in 2 weeks - it has a newly added section on Encryption which was the missing piece that should them safe to use for credential management.

@vito vito closed this as completed Jun 25, 2020
rymir pushed a commit to depop/registry-image-resource that referenced this issue Aug 26, 2021
This allows ECR to be used if a role is already assumed. Fixes concourse#94

Signed-off-by: Will Tran <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants