Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support pushing images up to the registry #2

Closed
vito opened this issue Aug 7, 2018 · 3 comments
Closed

Support pushing images up to the registry #2

vito opened this issue Aug 7, 2018 · 3 comments
Labels
enhancement New feature or request

Comments

@vito
Copy link
Member

vito commented Aug 7, 2018

We could really easily support pushing docker saved images, using these two methods:

This would mesh really well with a Kaniko-based task for doing the actual building. Related: https://github.com/concourse/rfcs/issues/7 and concourse/docker-image-resource#190 (comment)

We'll probably need auth support for this first (#1).

@vito vito added the enhancement New feature or request label Aug 7, 2018
@marco-m
Copy link

marco-m commented Dec 13, 2018

If I understand correctly there is preliminary support for pushing, for example in https://github.com/concourse/concourse/blob/master/ci/pipelines/concourse.yml:

  - put: unit-image
    params: {image: image/image.tar}

and the kaniko-based task is at https://github.com/concourse/builder, is this correct ?

Ah I saw the logs

WARN[0000] 'put' is experimental, untested, and subject to change! 

@vito
Copy link
Member Author

vito commented Dec 13, 2018

Yep, right now it's still experimental as I haven't worked out how we want to write tests for it yet, and I needed it sooner for our own pipeline in order for the docker-image-less pipeline experiment to continue.

The builder task uses img, but otherwise correct.

@vito
Copy link
Member Author

vito commented Dec 17, 2018

added a test for pushing - thank goodness for random.Image!

there is still much to be desired, namely being able to dynamically specify additional tags, but i've at least documented what (little) is there

the README also references the builder task

@vito vito closed this as completed Dec 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants