Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure plain http or insecure https for registry mirrors #120

Open
sclu1034 opened this issue Aug 28, 2024 · 0 comments · May be fixed by #121
Open

Configure plain http or insecure https for registry mirrors #120

sclu1034 opened this issue Aug 28, 2024 · 0 comments · May be fixed by #121
Labels
enhancement New feature or request

Comments

@sclu1034
Copy link

sclu1034 commented Aug 28, 2024

Is your feature request related to a problem? Please describe.

The REGISTRY_MIRRORS param merely allows defining the hosts. But the buildkit config also has fields http = true|false and insecure = true|false that allow resolving situations where the mirror doesn't support full HTTPS (e.g. an internal deployment).

Describe the solution you'd like

Expose additional variables to set http and insecure fields for repository mirrors.

Describe alternatives you've considered

The only alternative that comes to mind is to figure out how to bake a static buildkitd.toml into a custom version of this resource.

Additional context

No response

@sclu1034 sclu1034 added the enhancement New feature or request label Aug 28, 2024
sclu1034 added a commit to sclu1034/oci-build-task that referenced this issue Aug 29, 2024
Params like `REGISTRY_MIRRORS` don't really scale well to cover
a complex schema like buildkit's toml configuration. Plus, they
can become out-of-date.

A param whose content is written verbatim to the config file
allows defining everything the configuration has to offer, now
and in the future. It also avoids having to add new params one by
one as users request the ability to configure individual values.

Closes: concourse#120
@sclu1034 sclu1034 linked a pull request Aug 29, 2024 that will close this issue
sclu1034 added a commit to sclu1034/oci-build-task that referenced this issue Aug 29, 2024
Params like `REGISTRY_MIRRORS` don't really scale well to cover
a complex schema like buildkit's toml configuration. Plus, they
can become out-of-date.

A param whose content is written verbatim to the config file
allows defining everything the configuration has to offer, now
and in the future. It also avoids having to add new params one by
one as users request the ability to configure individual values.

Closes: concourse#120
Signed-off-by: Lucas Schwiderski <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant