Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code organization issues after successful spike into creating transposed results array. #14

Open
rklancer opened this issue Sep 21, 2012 · 0 comments

Comments

@rklancer
Copy link
Contributor

  1. This spike created a whole mess of new globals, model_md2d_results_RADIUS and friends, that need to be reconsidered and/or put into a namespace.
  2. It also added a long stanza to the already-overloaded computeOutputState method of md2d. This method needs to be split up into separate helpers each of which is responsible for one thing.
  3. That said, transposition is possibly a view concern and not the responsibility of the md2d engine at all, but rather of the overlying 'modeler'. (Following the rule that most things that don't need to be in the md2d closure to make the inner loop go, probably shouldn't be there.) I'll have to think about this more carefully, however.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant