Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All coordinates in model JSON should be specified in nm #13

Open
rklancer opened this issue Sep 17, 2012 · 1 comment
Open

All coordinates in model JSON should be specified in nm #13

rklancer opened this issue Sep 17, 2012 · 1 comment

Comments

@rklancer
Copy link
Contributor

Right now, image locations in converted JSON files are specified in "Classic length units" (units of length 0.1 Angstrom, which correspond to 1 pixel in Classic MW)

They should be specified in nm, like every other length value in model JSON files.

@rklancer
Copy link
Contributor Author

Image rendering code is making use of scaling_factor (which should be renamed to lengthUnitsPerPixel)

scaling_factor = (size.width/(modelSize[0]*100));

The factor of 100 should not be required. Moreover, the existing d3 scales x and y should be used instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant