-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add ptz to header list and added new version (3.0.1) #5706
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
self.copy(pattern="date.h", dst=dst, src=src) | ||
self.copy(pattern="tz.h", dst=dst, src=src) | ||
self.copy(pattern="ptz.h", dst=dst, src=src) | ||
self.copy(pattern="iso_week.h", dst=dst, src=src) | ||
self.copy(pattern="julian.h", dst=dst, src=src) | ||
self.copy(pattern="islamic.h", dst=dst, src=src) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like this is easier 🌮
self.copy(pattern="date.h", dst=dst, src=src) | |
self.copy(pattern="tz.h", dst=dst, src=src) | |
self.copy(pattern="ptz.h", dst=dst, src=src) | |
self.copy(pattern="iso_week.h", dst=dst, src=src) | |
self.copy(pattern="julian.h", dst=dst, src=src) | |
self.copy(pattern="islamic.h", dst=dst, src=src) | |
for file in ["date.h", "tz.h", "ptz.h", "iso_week.h", "julian.h", "islamic.h"]: | |
self.copy(pattern=file, dst=dst, src=src) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi. This is required? Because will reset reviews, build etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can add it after this PR, because this PR is required to use this library correctly. Can we do in this way?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not required, I approved! hopefully next time this recipe gets updated ... there's a few out of date conventions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
at university, on 1st semester, there was an exercise about for loop, the idea was print from 1 to 10 using C language. A colleague preferred to write printf 10 times, each line for a single number ... don't try it at home.
Please update the title to include the new version add please =) |
This comment has been minimized.
This comment has been minimized.
Unresolved graph? 😖 You'll need to retrigger CI, close the pr wait 10s and then re-open it 🔁 |
done |
all green again |
CI should merge it soon =) |
I think that need more one reviewer, no? |
Nop, CCI rules do not exactly work on GitHub https://github.com/conan-io/conan-center-index/blob/master/docs/review_process.md#getting-your-pull-request-reviewed My bot had this PR as "Ready to Merge" prince-chrismc/conan-center-index-pending-review#1 |
* add ptz to header list * add ptz to header list * add version 3.0.1 * add patch for version 3.0.1
Specify library name and version: date/all
This is also a good place to share with all of us why you are submitting this PR (specially if it is a new addition to ConanCenter): is it a dependency of other libraries you want to package? Are you the author of the library? Thanks!
conan-center hook activated.