Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding package with lib tree-sitter, version 0.17.3 #3791

Merged
merged 55 commits into from
Dec 9, 2020
Merged

Adding package with lib tree-sitter, version 0.17.3 #3791

merged 55 commits into from
Dec 9, 2020

Conversation

OleksiiKyslynskyi
Copy link
Contributor

Specify library name and version: tree-sitter/0.17.3

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

@conan-center-bot
Copy link
Collaborator

Some configurations of 'tree-sitter/0.17.3' failed in build 14 (5e2a5d7a6d2cb8bbfacfa3d75c0633af90280e74):

recipes/tree-sitter/all/conanfile.py Outdated Show resolved Hide resolved
Comment on lines 56 to 60
self.cpp_info.names["pkg_config"] = self.name
if self.options.shared:
self.cpp_info.libs = ["libtree-sitter.so"]
else:
self.cpp_info.libs = ["libtree-sitter.a"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
self.cpp_info.names["pkg_config"] = self.name
if self.options.shared:
self.cpp_info.libs = ["libtree-sitter.so"]
else:
self.cpp_info.libs = ["libtree-sitter.a"]
self.cpp_info.names["pkg_config"] = "tree-sitter"
self.cpp_info.libs = ["tree-sitter"]

recipes/tree-sitter/all/conanfile.py Outdated Show resolved Hide resolved
recipes/tree-sitter/all/conanfile.py Outdated Show resolved Hide resolved
@conan-center-bot
Copy link
Collaborator

All green in build 15 (86f8464c8d07d8817c97fbcf74dd68a757f94fa4)! 😊

madebr
madebr previously approved these changes Dec 6, 2020
@OleksiiKyslynskyi
Copy link
Contributor Author

@prince-chrismc @Croydon Hi! this pull request need 2 more approve from users with write access, can Your approve this merge?

@prince-chrismc
Copy link
Contributor

this pull request need 2 more approve from users with write access, can Your approve this merge?

Take a look at #2857 for how approvals work 😉

@OleksiiKyslynskyi
Copy link
Contributor Author

this pull request need 2 more approve from users with write access, can Your approve this merge?

Take a look at #2857 for how approvals work

In my previous PR Your already show me this ticket, but there was bug, that only admins can approve PR, hope with this PR only one admin member would be required!)

uilianries
uilianries previously approved these changes Dec 8, 2020
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

recipes/tree-sitter/all/conanfile.py Outdated Show resolved Hide resolved
@conan-center-bot
Copy link
Collaborator

All green in build 18 (927c8259a721aab0a89fd0aa4d84a39bdf715581)! 😊

@madebr
Copy link
Contributor

madebr commented Dec 8, 2020

@uilianries
This pr is missing your approval.

@conan-center-bot conan-center-bot merged commit 40b28fa into conan-io:master Dec 9, 2020
@IvanRibakov
Copy link
Contributor

@madebr @uilianries @prince-chrismc Hi all, thanks for your help with adding this dependency to Conan Center.

Although all CI checks have passed on this PR, it seems that CI process on master branch 40b28fa has failed:

image

I'm assuming this is the reason why I'm unable to find tree-sitter in the Conan Center.

Unfortunately I'm unable to see build failure details (403 Forbidden) - are any of you able to help with debugging this issue?

@Croydon
Copy link
Contributor

Croydon commented Dec 10, 2020

CI has some issues for a few days now. I believe that there is now a build job which adds missing binaries regularly, but if it does not appear soon, it might be better if you create a new issue to help tracking this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants