-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding package with lib tree-sitter, version 0.17.3 #3791
Conversation
Adding package with lib reSIProcate, version 1.12.0
Co-authored-by: Chris Mc <[email protected]>
Signed-off-by: Uilian Ries <[email protected]>
Improve ReSIProcate recipe
Co-authored-by: Chris Mc <[email protected]>
Some configurations of 'tree-sitter/0.17.3' failed in build 14 (
|
recipes/tree-sitter/all/conanfile.py
Outdated
self.cpp_info.names["pkg_config"] = self.name | ||
if self.options.shared: | ||
self.cpp_info.libs = ["libtree-sitter.so"] | ||
else: | ||
self.cpp_info.libs = ["libtree-sitter.a"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
self.cpp_info.names["pkg_config"] = self.name | |
if self.options.shared: | |
self.cpp_info.libs = ["libtree-sitter.so"] | |
else: | |
self.cpp_info.libs = ["libtree-sitter.a"] | |
self.cpp_info.names["pkg_config"] = "tree-sitter" | |
self.cpp_info.libs = ["tree-sitter"] |
All green in build 15 (
|
@prince-chrismc @Croydon Hi! this pull request need 2 more approve from users with write access, can Your approve this merge? |
Take a look at #2857 for how approvals work 😉 |
In my previous PR Your already show me this ticket, but there was bug, that only admins can approve PR, hope with this PR only one admin member would be required!) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Uilian Ries <[email protected]>
All green in build 18 (
|
@uilianries |
@madebr @uilianries @prince-chrismc Hi all, thanks for your help with adding this dependency to Conan Center. Although all CI checks have passed on this PR, it seems that CI process on I'm assuming this is the reason why I'm unable to find Unfortunately I'm unable to see build failure details ( |
CI has some issues for a few days now. I believe that there is now a build job which adds missing binaries regularly, but if it does not appear soon, it might be better if you create a new issue to help tracking this |
Specify library name and version: tree-sitter/0.17.3
conan-center hook activated.