-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
config: drop openssl from v2 ready since it does not work for 3.x version #16510
config: drop openssl from v2 ready since it does not work for 3.x version #16510
Conversation
Actually #15336 changes both openssl 1.x.x & 3.x.x, and c3i should ensure that 1.x.x still work with conan v2 |
OpenSSL 3.x.x is v2 ready in the sense that you can enable
builds successfully. It is not v2 ready in the sense that you can consume OpenSSL 3.x.x with a CMakeDeps & CMakeToolchain-based recipe. That only works for OpenSSL 1.x.x for which a v2 test package using the new generators is already on the master branch. The v2 test package with the new generators for OpenSSL 3.x.x and the fixed necessary to make it work will come with my PR #14426 I am not sure what the "c3i/conan-v2" CI tests for because I don't know the specifics and I cannot see results. If it only runs the command above and does not make sure that the test package uses the CMakeDeps generator, this PR is not needed. |
openssl 3.x.x is not v2 ready because it just can't work with conan v2 client due to usage of conan python API removed in conan v2 library, and therefore it can't pass v2 pipeline (a recipe can be consumed with new generators, but it doesn't mean it's compatible with conan v2 client), that's what this conan_v2_ready_references.yml is tracking, to ensure that once a recipe passes v2 pipeline, a new PR cannot break it. |
The variable does not actually change anything and only softly reports warnings. For example bad imports and not reported, it's very incomplete The v2 pipeline runs the 2.0 client and does a |
I'd highly recommend taking a look at the logs posted by the bot if you want a detailed break down of all the different commands. Conan 2.0 was released a few weeks ago and it's being used for CCI exclusively in its entirely for the v2 pipeline (aka there no v1 client) |
By the way, is this file updated regularly? Its content is a little bit odd:
(I've opened #16573) |
AutoMerge is not running over config PRs :/ |
@SpaceIm @jwillikers @toge Can you please review? The auto merge is bugged with team reviews 🙏 |
… work for 3.x version
Specify library name and version: lib/1.0
to unblock #15336