Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] Add "checkValidOnLastCellInput" option to only check the valid input on the last cell input #34

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

luongvo
Copy link
Contributor

@luongvo luongvo commented Aug 29, 2024

resolves #32

What happened 👀

  • Add "checkValidOnLastCellInput" option to only check the valid input on the last cell input.

Proof Of Work 📹

Screen_recording_20240829_083054.mp4

@luongvo luongvo force-pushed the feature/add-signal-when-reaching-the-last-cell branch from e93a808 to 526b7ab Compare August 29, 2024 01:51
@luongvo luongvo force-pushed the feature/add-signal-when-reaching-the-last-cell branch from 526b7ab to 9fb383a Compare August 29, 2024 01:54
@ilyasipek
Copy link
Collaborator

Hi @luongvo, thanks a lot for your contribution. However, I didn't fully understand the use case in which a developer would want to use such a flag.
Normally the developer would want to validate the OTP code when it's completed immediately.
For example, if the user enters 123450 and the actual code is 023456, the user will just change the first char and revalidate it.
In case the developer doesn't want that he can manually check if a validation happened before and then ignore the new onValid callback altogether.

For keeping the API minimal I think it's better to leave this kind of additional feature up to the developer to manage instead of adding a lot of config to the library, what do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

We need an event/signal to know when the user reaches the last cell
2 participants