Package components followup #6335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theobat
force-pushed
the
package-component-deps
branch
from
e4ac7f0 to
595bb9e
Compare
theobat
force-pushed
the
package-component-deps
branch
from
595bb9e to
c51f5e5
Compare
theobat
force-pushed
the
package-component-deps
branch
from
c51f5e5 to
e5b6344
Compare
theobat
force-pushed
the
package-component-deps
branch
from
0c93019 to
f138991
Compare
|
@theobat, thanks. It looked good to me, and I also tested it by using Stack to build Stack. I did a little reformatting and I preferred shorter |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is simply the further consequences of the design merged in #6334.
In particular, it removes the ugly wart that was
PackageDescriptionPairand realise most of the plan/changes that I described and proposed in #5920 (comment)