Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form field label translations? #44

Closed
sandermarechal opened this issue Oct 22, 2015 · 4 comments
Closed

Form field label translations? #44

sandermarechal opened this issue Oct 22, 2015 · 4 comments

Comments

@sandermarechal
Copy link

Could you add support for translating form field labels? The address form itself works great but all labels are always displayed in English. I don't know which translation keys I should translate for all the possible form fields.

@bojanz
Copy link
Contributor

bojanz commented Oct 22, 2015

That can't be done in the library itself, it needs to be done on the application / bundle level (since different apps and frameworks use different translation methods).

So a symfony bundle could rely on symfony's translation component and provide yaml files with the strings.

@sandermarechal
Copy link
Author

Yes, I understand. But this library could use proper key IDs instead of plain language strings (e.g. 'address.city' instead of 'City') and document what all possible translation keys are.

You could even opt to provide translations in XLIFF format in the resources directory. XLIFF is an international standard and is framework independent. No need to load these files, just provide them as part of the package so that developers can load them themselves.

@dnagirl
Copy link
Contributor

dnagirl commented Nov 6, 2015

This would be awesome!

@bojanz
Copy link
Contributor

bojanz commented Apr 19, 2017

Since then the form integration was removed, and a new one is being built in #66. I'll add a note to that issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants