"Preview" does not do anything in "New canned response" form

[fingolfin]

So since editing global canned responses has the problem of not showing "add" or "edit" links, I instead am playing with adding project specific canned responses.

Going to /projects/test/settings/canned_responses shows a nice "New canned response" link. Following that, I arrive on /projects/test/canned_responses/new. So I enter some test in the Title and Response Text fields, and press the "preview" link -- and nothing happens. Well, not quite true: a "Loading..." overlay pop up for a fraction of a second, but nothing is shown.

So either the "Preview" button should be fixed, or removed. Well, or I again missed something :-).

[a1exsh]

Sorry, looks like this functionality depends on this commit I forgot to submit upstream: commandprompt/redmine@b231b79

Doing that now. Thanks for your continued interest in this plugin!

[a1exsh]

Hm, actually this should fix it: 2628b7d

I recall having some weird problem with the POST route to preview before, to the point that I've used GET instead. Now that I try with the recent redmine version, it works like it should.

[fingolfin]

With your change, preview now indeed works when creating a new canned response. However, it doesn't seem to work when editing an existing one. Weird.

[a1exsh]

On Thu, Mar 28, 2013 at 10:27 PM, Max Horn [email protected] wrote:

With your change, preview now indeed works when creating a new canned
response. However, it doesn't seem to work when editing an existing one.
Weird.

I knew it!

Started PUT "/canned_responses/preview" for 195.88.15.88 at 2013-03-28
13:29:37 -0700
Processing by CannedResponsesController#update as /

The problem seems to be that in presence of resource id it tries PUT
instead of POST. Need to look at the issue update/preview code...