PR: Implement Support for Executing CLF Workflows #1310
+66,996
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelMauderer
force-pushed
the
feature/CLF_execution
branch
from
249fa6a
to
fe57049
Compare
KelSolaar
changed the title
KelSolaar
requested changes
Nov 14, 2024
| @@ -49,8 +49,12 @@ dependencies = [ | |||
| "numpy>=1.24,<3", | |||
| "scipy>=1.10,<2", | |||
| "typing-extensions>=4,<5", | |||
| "colour-clf-io" | |||
There was a problem hiding this comment.
Major
This should be an optional dependency as we do not want to hard-depend on CLF.
We will thus need a new requirement entry and callable here: https://github.com/colour-science/colour/blob/develop/colour/utilities/requirements.py
We will also want to track its version in colour.utilities.describe_environment
| ] | ||
|
|
||
| [tool.uv.sources] | ||
| colour-clf-io = {git = 'https://github.com/colour-science/colour-clf-io.git'} |
There was a problem hiding this comment.
Minor
This is fine for now but we will need to release it on Pypi.
|
|
||
| import numpy.typing as npt | ||
| from colour_clf_io import ExponentStyle | ||
| from colour_clf_io.values import Channel |
There was a problem hiding this comment.
Minor
Do you have the precommit hooks running, it looks like isort is not really running.
| return result | ||
|
|
||
|
|
||
| def apply( |
There was a problem hiding this comment.
Major
We should try to use colour.io.LUTSequence here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add support for executing CLF workflows defined as per https://docs.acescentral.com/specifications/clf/#common-lut-format-clf-a-common-file-format-for-look-up-tables
Closes #636
TODO
pyproject.tomlto use that instead of directly referring to the repo.Preflight
Code Style and Quality
colour,colour.models.Documentation