From 9779d45f6509c01a52b1f13195d199ce9fcc1954 Mon Sep 17 00:00:00 2001 From: jclausen Date: Tue, 23 Jul 2024 18:19:40 -0600 Subject: [PATCH] fix secrets usage --- .github/workflows/tests.yml | 28 +++++++++++++++------------- 1 file changed, 15 insertions(+), 13 deletions(-) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index 6424880..26a0505 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -4,6 +4,8 @@ name: Test Suites on: workflow_call: secrets: + STRIPE_API_KEY: + required: true SLACK_WEBHOOK_URL: required: false @@ -53,7 +55,7 @@ jobs: # Setup .env touch .env # ENV - printf "STRIPE_API_KEY=${{ env.STRIPE_API_KEY }}\n" >> .env + printf "STRIPE_API_KEY=${{ secrets.STRIPE_API_KEY }}\n" >> .env - name: Install Test Harness with ColdBox ${{ matrix.coldboxVersion }} run: | @@ -98,15 +100,15 @@ jobs: .engine/**/logs/* .engine/**/WEB-INF/cfusion/logs/* - - name: Slack Notifications - # Only on failures and NOT in pull requests - if: ${{ failure() && !startsWith( 'pull_request', github.event_name ) }} - uses: rtCamp/action-slack-notify@v2 - env: - SLACK_CHANNEL: coding - SLACK_COLOR: ${{ job.status }} # or a specific color like 'green' or '#ff00ff' - SLACK_ICON_EMOJI: ":bell:" - SLACK_MESSAGE: '${{ github.repository }} tests failed :cry:' - SLACK_TITLE: ${{ github.repository }} Tests For ${{ matrix.cfengine }} with ColdBox ${{ matrix.coldboxVersion }} failed - SLACK_USERNAME: CI - SLACK_WEBHOOK: ${{ secrets.SLACK_WEBHOOK_URL }} + # - name: Slack Notifications + # # Only on failures and NOT in pull requests + # if: ${{ failure() && !startsWith( 'pull_request', github.event_name ) }} + # uses: rtCamp/action-slack-notify@v2 + # env: + # SLACK_CHANNEL: coding + # SLACK_COLOR: ${{ job.status }} # or a specific color like 'green' or '#ff00ff' + # SLACK_ICON_EMOJI: ":bell:" + # SLACK_MESSAGE: '${{ github.repository }} tests failed :cry:' + # SLACK_TITLE: ${{ github.repository }} Tests For ${{ matrix.cfengine }} with ColdBox ${{ matrix.coldboxVersion }} failed + # SLACK_USERNAME: CI + # SLACK_WEBHOOK: ${{ secrets.SLACK_WEBHOOK_URL }}