Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On a new install of angular 7 getting errors. #29

Open
obiyoda opened this issue Mar 15, 2019 · 9 comments
Open

On a new install of angular 7 getting errors. #29

obiyoda opened this issue Mar 15, 2019 · 9 comments

Comments

@obiyoda
Copy link

obiyoda commented Mar 15, 2019

Getting this error when running the ng serve command
ERROR in node_modules/@colap-dev/ngx-britecharts/node_modules/rxjs/Subject.d.ts(24,5): error TS2416: Property 'lift' in type 'Subject<T>' is not assignable to the same property in base type 'Observable<T>'. Type '<R>(operator: Operator<T, R>) => Observable<T>' is not assignable to type '<R>(operator: Operator<T, R>) => Observable<R>'. Type 'Observable<T>' is not assignable to type 'Observable<R>'. Type 'T' is not assignable to type 'R'. node_modules/@colap-dev/ngx-britecharts/node_modules/rxjs/observable/dom/WebSocketSubject.d.ts(77,5): error TS2416: Property 'lift' in type 'WebSocketSubject<T>' is not assignable to the same property in base type 'AnonymousSubject<T>'. Type '<R>(operator: Operator<T, R>) => WebSocketSubject<R>' is not assignable to type '<R>(operator: Operator<T, R>) => Observable<T>'. Type 'WebSocketSubject<R>' is not assignable to type 'Observable<T>'. Types of property 'operator' are incompatible. Type 'Operator<any, R>' is not assignable to type 'Operator<any, T>'. Type 'R' is not assignable to type 'T'.

@martinmanzo
Copy link
Contributor

Hi @obiyoda , could you please provide more info?

Knowing the Angular and Typescript version you are using would really help.

@obiyoda
Copy link
Author

obiyoda commented Mar 16, 2019

Angular version is 7.2.0
Typescript version is 3.2.2

Below is my package.json. This is all spun up using the angular cli.

{
  "name": "ng7error",
  "version": "0.0.0",
  "scripts": {
    "ng": "ng",
    "start": "ng serve",
    "build": "ng build",
    "test": "ng test",
    "lint": "ng lint",
    "e2e": "ng e2e"
  },
  "private": true,
  "dependencies": {
    "@angular/animations": "~7.2.0",
    "@angular/common": "~7.2.0",
    "@angular/compiler": "~7.2.0",
    "@angular/core": "~7.2.0",
    "@angular/forms": "~7.2.0",
    "@angular/platform-browser": "~7.2.0",
    "@angular/platform-browser-dynamic": "~7.2.0",
    "@angular/router": "~7.2.0",
    "@colap-dev/ngx-britecharts": "^1.0.1",
    "core-js": "^2.5.4",
    "rxjs": "~6.3.3",
    "tslib": "^1.9.0",
    "zone.js": "~0.8.26"
  },
  "devDependencies": {
    "@angular-devkit/build-angular": "~0.13.0",
    "@angular/cli": "~7.3.6",
    "@angular/compiler-cli": "~7.2.0",
    "@angular/language-service": "~7.2.0",
    "@types/node": "~8.9.4",
    "@types/jasmine": "~2.8.8",
    "@types/jasminewd2": "~2.0.3",
    "codelyzer": "~4.5.0",
    "jasmine-core": "~2.99.1",
    "jasmine-spec-reporter": "~4.2.1",
    "karma": "~4.0.0",
    "karma-chrome-launcher": "~2.2.0",
    "karma-coverage-istanbul-reporter": "~2.0.1",
    "karma-jasmine": "~1.1.2",
    "karma-jasmine-html-reporter": "^0.2.2",
    "protractor": "~5.4.0",
    "ts-node": "~7.0.0",
    "tslint": "~5.11.0",
    "typescript": "~3.2.2"
  }
}

@martinmanzo
Copy link
Contributor

We haven't still made the library offialy compatible with Angular 7 so that may be the issue.

Any way you can try one of this things:

Please let me know if any of those 2 options helped.

@martinmanzo
Copy link
Contributor

Hi @obiyoda, did any of those option worked?

@obiyoda
Copy link
Author

obiyoda commented Mar 22, 2019 via email

@eliraneliassy
Copy link

Is someone working on this?
@martinmanzo

@martinmanzo
Copy link
Contributor

Hi @eliraneliassy , not that I'm aware of. Are you thinking on taking it?

@cabrinoob
Copy link

Same error here.

ERROR in node_modules/@colap-dev/ngx-britecharts/node_modules/rxjs/Subject.d.ts(24,5): error TS2416: Property 'lift' in type 'Subject<T>' is not assignable to the same property in base type 'Observable<T>'.

@martinmanzo
Copy link
Contributor

martinmanzo commented Oct 24, 2019

Hello @cabrinoob , I didn't had the time to make the package compatible with Angular 7 so that is the issue. Would you mind making a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants