Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input elements lack consistency. #97

Open
Cerbrus opened this issue Nov 10, 2023 · 3 comments
Open

Input elements lack consistency. #97

Cerbrus opened this issue Nov 10, 2023 · 3 comments
Assignees
Labels
area: components Changes to design components complexity: average The issue is not particularly hard but requires effort to resolve type: bug Something isn't working

Comments

@Cerbrus
Copy link

Cerbrus commented Nov 10, 2023

Describe the bug

There's a lot of inconsistency in the styling of input elements and buttons:

  • Input elements are rendered with different background colors, borders and even sizes.
  • Buttons aren't aligned, and inconsistently either have a border or a background color
  • (The "expand/collapse" arrow for the filter expansion is huge)

See screenshot.

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://software.codidact.com/
  2. Click on 'Filters (None)'
  3. See layout / styling issues

Expected behavior

  • I'd expect all input elements to be the same size, color, and have the same borders.
  • I'd expect all buttons to be aligned vertically.
  • I'd expect all buttons to have consistent styling. (border / background color: Either everything has a border, or nothing)

Screenshots

image

Desktop:

  • OS: Windows
  • Browser: Chrome
  • Version: 119.0.6045.106 (Official Build) (64-bit)

Additional details

The CSS responsible for the (mis-)alignment of that [apply] button is this:

@media screen and (min-width: 780px)
.form-group-horizontal>:last-child {
    margin: 0 0 0 0.5em !important;
}

Disabling that fixes the alignment:
image

@cellio cellio added type: bug Something isn't working area: components Changes to design components labels Nov 10, 2023
@cellio
Copy link
Member

cellio commented Nov 10, 2023

@MoshiKoi is this an issue in co-design itself or in how the filters code is using it?

@Oaphi Oaphi self-assigned this Nov 11, 2023
@Oaphi Oaphi added the complexity: average The issue is not particularly hard but requires effort to resolve label Nov 11, 2023
@MoshiKoi
Copy link
Member

Is there a reason for that piece of code that was misaligning the last button? It's marked important after all.

@Oaphi
Copy link
Member

Oaphi commented Nov 12, 2023

Is there a reason for that piece of code that was misaligning the last button? It's marked important after all.

@MoshiKoi yes, unfortunately, there is - apparently, it exists to align horizontal form elements (see screenshot).
I plan to style the filters component with its own ruleset - that should solve the immediate problem.
However, the .form-group-horizontal's rulesets likely need to be rethought as well.

2023-11-12_05-29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: components Changes to design components complexity: average The issue is not particularly hard but requires effort to resolve type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants