Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Grafana API Keys #86

Closed
wants to merge 2 commits into from

Conversation

kwapik
Copy link

@kwapik kwapik commented Oct 6, 2023

Summary by CodeRabbit

  • Refactor: Updated the Middleware function in the ContextHandler struct within contexthandler.go. The initialization of context with API keys, including the initContextWithAPIKey function call and basic authentication, has been disabled. This change enhances compatibility with Aperture Cloud User API Keys.

@github-actions
Copy link

github-actions bot commented Oct 6, 2023

Image description CodeRabbit

Walkthrough

This change set primarily focuses on disabling the initialization of context with API keys in the Middleware function of the ContextHandler struct. The modification was necessary due to the incompatibility of these methods with Aperture Cloud User API Keys.

Changes

File Summary
pkg/services/contexthandler/contexthandler.go The diff disables the initialization of the context with API keys in the Middleware function of the ContextHandler struct, including the initContextWithAPIKey function call and basic authentication. This change is made because these methods do not work with Aperture Cloud User API Keys.

🐇

In the land of code, where logic intertwines,

A rabbit hops, making changes line by line.

With each leap forward, an issue's put to rest,

Celebrate this moment, for it's one of our best! 🎉


Uplevel your code reviews with CodeRabbit Pro

CodeRabbit Pro

If you like this project, please support us by purchasing the Pro version. The Pro version has advanced context, superior noise reduction and several proprietary improvements compared to the open source version. Moreover, CodeRabbit Pro is free for open source projects.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image description CodeRabbit

Commits Files that changed from the base of the PR and between 62ae185 and 129581a commits.
Files selected (1)
  • pkg/services/contexthandler/contexthandler.go (1)
Files skipped from review due to trivial changes (1)
  • pkg/services/contexthandler/contexthandler.go
Review comments generated (0)
  • Review: 0
  • LGTM: 0

Tips

Chat with Image description CodeRabbit Bot (@coderabbitai)

  • Reply on review comments left by this bot to ask follow-up questions. A review comment is a comment on a diff or a file.
  • Invite the bot into a review comment chain by tagging @coderabbitai in a reply.

Code suggestions

  • The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
  • You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.

Pausing incremental reviews

  • Add @coderabbitai: ignore anywhere in the PR description to pause further reviews from the bot.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image description CodeRabbit

Commits Files that changed from the base of the PR and between 129581a and 7e98b3e commits.
Files selected (1)
  • pkg/services/contexthandler/contexthandler.go (1)
Files skipped from review due to trivial changes (1)
  • pkg/services/contexthandler/contexthandler.go
Review comments generated (0)
  • Review: 0
  • LGTM: 0

Tips

Chat with Image description CodeRabbit Bot (@coderabbitai)

  • Reply on review comments left by this bot to ask follow-up questions. A review comment is a comment on a diff or a file.
  • Invite the bot into a review comment chain by tagging @coderabbitai in a reply.

Code suggestions

  • The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
  • You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.

Pausing incremental reviews

  • Add @coderabbitai: ignore anywhere in the PR description to pause further reviews from the bot.

@kwapik
Copy link
Author

kwapik commented Nov 14, 2023

Obsolete.

@kwapik kwapik closed this Nov 14, 2023
@kwapik kwapik deleted the kwapik/disable_api_keys branch November 14, 2023 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant