Add fnLoader in grafana instead of using a prop from parent mfe #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
WalkthroughThe changes introduce a new loading component Changes
Uplevel your code reviews with CodeRabbit ProCodeRabbit ProIf you like this project, please support us by purchasing the Pro version. The Pro version has advanced context, superior noise reduction and several proprietary improvements compared to the open source version. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Files selected (4)
- public/app/features/dashboard/components/DashboardLoading/FnLoader.tsx (1)
- public/app/features/dashboard/containers/DashboardPage.tsx (4)
- public/app/fn-app/fn-dashboard-page/render-fn-dashboard.tsx (2)
- public/app/fn-app/types.ts (1)
Files ignored due to filter (4)
- package.json
- public/app/features/dashboard/components/DashboardLoading/fn-logo.svg
- public/app/features/dashboard/components/DashboardLoading/fn-lottie-loader.json
- yarn.lock
Files skipped from review due to trivial changes (2)
- public/app/features/dashboard/components/DashboardLoading/FnLoader.tsx
- public/app/features/dashboard/containers/DashboardPage.tsx
Review comments generated (3)
- Review: 3
- LGTM: 0
Tips
Chat with 
CodeRabbit Bot (@coderabbitai)
- Reply on review comments left by this bot to ask follow-up questions. A review comment is a comment on a diff or a file.
- Invite the bot into a review comment chain by tagging
@coderabbitaiin a reply.
Code suggestions
- The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
- You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.
Pausing incremental reviews
- Add
@coderabbitai: ignoreanywhere in the PR description to pause further reviews from the bot.
gurinder39
approved these changes
Aug 31, 2023
GurinderRawala
pushed a commit
that referenced
this pull request
Aug 27, 2024
GurinderRawala
added a commit
that referenced
this pull request
Sep 3, 2024
* [v9.3.x] OAuth: Refactor OAuth parameters handling to support obtaining refresh tokens for Google OAuth (grafana#58940) OAuth: Refactor OAuth parameters handling to support obtaining refresh tokens for Google OAuth (grafana#58782) * Add ApprovalForce to AuthCodeOptions * Extract access token validity check to a function * Refactor * Oauth: set options internally instead of exposing new function * Align tests * Remove unused function Co-authored-by: Karl Persson <[email protected]> (cherry picked from commit 9c98314) Co-authored-by: Misi <[email protected]> * [v9.3.x] Preferences: Add confirmation modal when saving org preferences (grafana#59119) (grafana#59141) * Navigation: share logic between `buildBreadcrumbs` and `usePageTitle`… (grafana#59155) Navigation: share logic between `buildBreadcrumbs` and `usePageTitle` (grafana#58819) * simplify usePageTitle logic a bit * use buildBreadcrumbs logic in usePageTitle * always add home item to navTree, fix some tests * fix remaining unit tests (cherry picked from commit 824a562) * [v9.3.x] CloudWatch: Cross-account querying support (grafana#59389) * add cross-account querying support * fix tests * FN FluxNinja changes * Run `go mod tidy` * Fix druid plugin registration * FN FluxNinja changes * FN FluxNinja changes * Build: Streamline and sync dockerfiles (grafana#58101) * streamline and sync dockerfiles * improve go dependency cacheability * unify alpine and ubuntu Dockerfiles * include glibc support in locally-built alpine images * FN Remove internationalization provider * FN Update sankey panel (30b5be0b5bf03ee8c7) * FN Render filters and time selector, hide loader despite pageNav and sectionNav * FN Remove tenary expressions with explicit booleans in DashNav * FN Use optional chaining - keybindingSrv in initDashboard * FN Set isPublicDashboardView to false * FN Set hiddenVariables in initial FN state * FN Lint RenderFnDashboard * FN Lint create-mfe * Updated SSH Keys (#43) * Time range selector changes (#42) * changed time picker dropdown designs * change time setting button * added dark and light * 7829 Read hiddenVariables, mode, FNDashboard from grfana's state (#44) Co-authored-by: Katarzyna Ziomek-Zdanowicz <[email protected]> * Add tool versions (#45) Co-authored-by: Katarzyna Ziomek-Zdanowicz <[email protected]> * Added support for updating nightly environment (#46) * 7911 Add graphql datasource plugin (#47) * 7911 Update FN_README * 7911 Add graphql plugin * 7911 Add graphql plugin Co-authored-by: Katarzyna Ziomek-Zdanowicz <[email protected]> * 7911 Allow loading unsigned graphql plugin (#49) Co-authored-by: Katarzyna Ziomek-Zdanowicz <[email protected]> * 7911 Modify url in graphql datasource plugin (#50) Co-authored-by: Katarzyna Ziomek-Zdanowicz <[email protected]> * Minor grafadruid fixes (#51) * Support Druid GroupBy queries (#52) * 8225 Fix missing grafana loader (#53) Co-authored-by: Katarzyna Ziomek-Zdanowicz <[email protected]> * Fix ad hoc filters (#54) * 8238 Remove panel header menu (#55) Co-authored-by: Katarzyna Ziomek-Zdanowicz <[email protected]> * added presisted time range (#56) * Updates to latest instead of demo environment (#57) * Loading dashboards with update function (#58) * changed dashboard loading to use update fn * removed extra package * changed query filter designs (#59) * Add ChatGPT-based PR Reviewer and Summarizer (#62) * fix (#63) * 8822 ci (#66) * 8822 Remove dashes from dashboard filter labels * 8822 Empty commit --------- Co-authored-by: Katarzyna Ziomek-Zdanowicz <[email protected]> * 8740 Fix variables in titles by using PanelHeader component to render panel header (#64) Co-authored-by: Katarzyna Ziomek-Zdanowicz <[email protected]> * update action * update review job name (#69) * Load dashboard with specific version passed from FN UI (#68) * Add full metadata for versions query too (#70) * 8963 Remove edit icons in dashboard row (#71) Co-authored-by: Katarzyna Ziomek-Zdanowicz <[email protected]> * Update openai-review.yml (#73) * Update openai-review.yml * update action * Fix table panel (#75) * Grafana firefox (#77) * vscode fix * fixed firefox bugs --------- Co-authored-by: Gurinder Singh <[email protected]> * Pull latest time range changes from upstream grafana (#78) * Support math expressions for druid granularity (#81) * Remove font size from global styles (#82) * Add fnLoader in grafana instead of prop from parent mfe (#83) * Fixed CircleCI config (#84) * Font update, bug fixes (#85) * Fix grafana bugs * Update grafana font to source sans pro * Revert code format change * replace function error fix (#87) * Add missing config in opsninja.yaml (#88) * Update font to Source Sans Pro (#90) * filter label design fix (#92) * druid datasource fixes (#93) * druid datasource fixes * wire gen fix * page definations fix (#94) * Fix headers in Druid DS (#97) Co-authored-by: Jakub Michalak <[email protected]> * Pass headers to Druid query (#99) * Fix headers in Druid variable queries (#100) * typing error fix and modifications (#101) * typing error fix and modifications * react-use module installed * Fix type error and adhoc filter alignment * Fix one more type error --------- Co-authored-by: Spikatrix <[email protected]> * render time range selector any where, removed dead code (#103) * removed graphql data source, updated local test info in fn readme * portal for time range selector * Enable panel resizing (#105) * Adhoc filter fix, update sankey plugin (#106) * Adhoc filter style fix * Update sankey plugin * confirm grafana initialization (#107) * window event to confirm initialization * grafana start up status events * Show filters icon only when there are some variables to show (#116) * Don't panic on empty var Druid query (#123) * Remove not needed GH Actions (#124) * changed to cirular progress (#148) * changed to cirular progress * codeRabbit suggestions * remove reviewer * loader color fix (#150) * page title Flux Ninja -> FluxNinja * Add allowed cookies field in druid datasource settings (#171) * Fix sentry heatmap crash (#168) Co-authored-by: Gurinder Singh <[email protected]> * removed make doc workflow (#172) * Coderabbit theme and fixes (#175) * coderabbit theme * theme change * checkpoint * fixes * added coderabbit authentication * Create deploy-cloud-run-grafana.yaml (#176) * Update deploy-cloud-run-grafana.yaml * Update deploy-cloud-run-grafana.yaml with CD * webpack fix for prod (#177) * added GH for prod (#178) Co-authored-by: dikshant <[email protected]> * Deploy grafana image to cloud run * Update deploy-cloud-run-grafana-prod.yaml * dashboard style changes (#179) * disabled drag for mfe (#180) * changed error message to no data (#182) * fix * log fix * rebase issues resolved * webpack changes * mfe fix * checkpoint * tooltip, icons fix * deleted github actions * dependency updates fix * fixes --------- Co-authored-by: Grot (@grafanabot) <[email protected]> Co-authored-by: Misi <[email protected]> Co-authored-by: Joao Silva <[email protected]> Co-authored-by: Ashley Harrison <[email protected]> Co-authored-by: Erik Sundell <[email protected]> Co-authored-by: Katarzyna Ziomek-Zdanowicz <[email protected]> Co-authored-by: Krzysztof Kwapisiewicz <[email protected]> Co-authored-by: Dan Cech <[email protected]> Co-authored-by: Hardik Shingala <[email protected]> Co-authored-by: Gurinder Singh <[email protected]> Co-authored-by: Kasia <[email protected]> Co-authored-by: Szymon Bieńkowski <[email protected]> Co-authored-by: Jakub Michalak <[email protected]> Co-authored-by: Harjot Gill <[email protected]> Co-authored-by: Daria Bialobrzeska <[email protected]> Co-authored-by: Gurinder Singh <[email protected]> Co-authored-by: Jaseel <[email protected]> Co-authored-by: Gurinder Singh <[email protected]> Co-authored-by: dikshant-infracloud <[email protected]> Co-authored-by: dikshant <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves https://github.com/fluxninja/cloud/issues/10919
Summary by CodeRabbit
FnLoadercomponent to enhance the loading state visualization with FluxNinja logo and optional text.DashboardLoadingcomponent with the newFnLoaderin theUnthemedDashboardPageclass, improving the user experience during loading states.fnLoaderprop from theRenderFNDashboardcomponent and theFNDashboardPropsinterface, simplifying the component's usage and reducing complexity.