Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add What's New/Digest Functionality & Storage Updates #38

Merged
merged 27 commits into from
Sep 27, 2024
Merged

Add What's New/Digest Functionality & Storage Updates #38

merged 27 commits into from
Sep 27, 2024

Conversation

scottstraughan
Copy link
Member

@scottstraughan scottstraughan commented Sep 25, 2024 •
edited
Loading

image

This PR does the following:

  • Adds a "What's New" page. This page allows users to quickly see what has changed since their last visit
    • Page will show all changes between a start date and an end date
    • Page will allow users to change the start date
    • Page will automatically store the current date, as the last date
  • Migrated to a slightly better storage solution, motivated by the "Whats New" page
    • Ensures that all cookies are defined in the environments file
    • Throws exceptions and disallows storing of data to local storage if its not enabled
  • Added alert service
  • Multiple improvements and fixes

@scottstraughan
Created new safe-storage.service.ts that takes over the storing of al…
299e49f 
…l data to the persistent storage.

The motivation behind this is to ensure that all cookies and data storage is defined and  to ensure data is never stored if it isn't allowed.
@scottstraughan
UI tweaks to popups.
6bc73b2
@scottstraughan
Added new "changed" page that allows users to quickly see what has be…
b40dcc1 
…en updated/changed on SYCL.tech.
@scottstraughan
UI fix.
251fedb
@scottstraughan
Small bug fix.
f34d35f
@scottstraughan scottstraughan marked this pull request as draft September 25, 2024 15:39
@scottstraughan
Slightly better messaging.
a555796
@scottstraughan
Tidied up the messaging slightly.
9be3b66
@scottstraughan
Tweaks to cookie page to add missing cookies and tweak table ui.
e69b8c7
@scottstraughan
Removed automatic last-visit saving on changed page, it's not reaquired.
667517e
@scottstraughan
Added standalone changed.service.ts to share code across site.
8ce4657
@scottstraughan
Added missing cookies to allowed cookie key list.
9c1b491
@scottstraughan
Added home page alert.
1ea6237
@scottstraughan
Added missing storage keys.
5b5c940
@scottstraughan
Added alerts service to main page to allow all pages to set alerts.
233491a
@scottstraughan
Added default enabled alerts when the storage service state is enable…
6df1e83 
…d/disabled.
@scottstraughan
Removed unused code.
2c3505e
@scottstraughan
Revamped how the alert service works.
77ba4b8
@scottstraughan
Updated to a bottom, right alert based service that allows multiple a…
1b28992 
…lerts to be shown.
@scottstraughan
Updated settings page to allow enabling/disabling of alerts.
c3a896b
@scottstraughan
Added some alerts to home and playground.
1a2c305
@scottstraughan
Bug fixes to cookie page and popup.
2a0bad5
@scottstraughan
Updated changed.component.ts page to ensure a default date is set.
6c9af63
@scottstraughan
Bug fixes to ensure subscriptions are properly closed or are self-clo…
7aa4ecd 
…sing.
@scottstraughan
Improved comments.
5110f0b
@scottstraughan
Variable name tweaks for consistency.
01e111b
@scottstraughan scottstraughan marked this pull request as ready for review September 27, 2024 12:06
codeplaymax
codeplaymax previously approved these changes Sep 27, 2024
View reviewed changes
@codeplaymax
Copy link
Collaborator

This is great Scott!

@scottstraughan
Copy link
Member Author

Thanks @codeplaymax . Could you re-approve? Noticed a small bug which is now fixed.

codeplaymax
codeplaymax previously approved these changes Sep 27, 2024
View reviewed changes
@scottstraughan scottstraughan merged commit 84de683 into main Sep 27, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeplaymax codeplaymax codeplaymax approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scottstraughan @codeplaymax