Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code review request #1

Open
GoogleCodeExporter opened this issue Mar 29, 2015 · 1 comment
Open

Code review request #1

GoogleCodeExporter opened this issue Mar 29, 2015 · 1 comment

Comments

@GoogleCodeExporter
Copy link

Branch name: default

The service is ready for publishing. Could you please review its code?

Sincerely,
Vlad

Original issue reported on code.google.com by [email protected] on 29 Nov 2012 at 5:42

@GoogleCodeExporter
Copy link
Author

1. newElem.find('[id]').each(function(index) {
                $(this).attr('id', $(this).attr('id') + newNum);
});
=> could be replaced with 
newElem.find('[id]').attr(....)

2. $(newElem.find('.clonable-remove-button:first')).click(...)
=> double $(), newElem.find().click(...) is enough

3. $('.s3index-error-msg').each(function(index) {
    $(this).remove();
  });
and similar code could be replaced with: 
$('.s3index-error-msg').remove()





Original comment by [email protected] on 27 Feb 2013 at 6:11

  • Added labels: ****
  • Removed labels: ****

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant