Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Large packets result in error and unexpected connection loss #11

Open
GoogleCodeExporter opened this issue Mar 28, 2015 · 3 comments
Open

Comments

@GoogleCodeExporter
Copy link

amqp.inc at around ln 390

if(false == ($written = fwrite($this->sock, $data)))

should be

if(false === ($written = fwrite($this->sock, $data)))


If you're sending a large packet, fwrite may sit around (not sending data),
waiting for room to appear in the buffer. In the mean time, fwrite is
returning 0, even though there isn't an error.

(return value should be strictly false if there is an error, not 0)

Original issue reported on code.google.com by [email protected] on 12 Dec 2009 at 4:01

@GoogleCodeExporter
Copy link
Author

Observed this when run within Windows XP instance under VirtualBox -> errno 
10054 
(WSAECONNRESET)

Original comment by [email protected] on 5 Feb 2010 at 5:12

  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author

[deleted comment]

@GoogleCodeExporter
Copy link
Author

Lyolik please review these bugs.

Original comment by [email protected] on 21 Mar 2010 at 9:17

  • Added labels: ****
  • Removed labels: ****

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant