-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev: phpunit 15 risky & 3 failures tests #802
Labels
Comments
datamweb
changed the title
Dev: phpunit 15 risky tests
Dev: phpunit 15 risky & 3 failures tests
Aug 26, 2023
The following appear to be affected by Merger #796 . There was 1 error:
1) Tests\Unit\Authentication\JWT\JWTManagerTest::testParseCanSpecifyKey
ErrorException: Undefined array key "mobile"
/home/runner/work/shield/shield/src/Authentication/JWT/Adapters/FirebaseAdapter.php:145
/home/runner/work/shield/shield/src/Authentication/JWT/Adapters/FirebaseAdapter.php:112
/home/runner/work/shield/shield/src/Authentication/JWT/JWSEncoder.php:62
/home/runner/work/shield/shield/src/Authentication/JWTManager.php:[73](https://github.com/codeigniter4/shield/actions/runs/5984579479/job/16235976345?pr=801#step:11:74)
/home/runner/work/shield/shield/tests/Unit/Authentication/JWT/JWTManagerTest.php:311
--
There were 3 failures:
1) Tests\Unit\Authentication\JWT\JWTManagerTest::testIssueWithAsymmetricKey
Failed asserting that two arrays are identical.
--- Expected
+++ Actual
@@ @@
Array &0 (
'typ' => 'JWT'
- 'alg' => 'RS256'
+ 'alg' => 'HS256'
)
/home/runner/work/shield/shield/tests/Unit/Authentication/JWT/JWTManagerTest.php:227
2) Tests\Unit\Authentication\JWT\JWTManagerTest::testIssueSetKid
Failed asserting that two arrays are identical.
--- Expected
+++ Actual
@@ @@
Array &0 (
'typ' => 'JWT'
'alg' => 'HS256'
- 'kid' => 'Key01'
)
/home/runner/work/shield/shield/tests/Unit/Authentication/JWT/JWTManagerTest.php:151
3) Tests\Unit\Authentication\JWT\Adapters\FirebaseAdapaterTest::testEncodeLogicExceptionLogicException
Failed asserting that exception of type "CodeIgniter\Shield\Exceptions\LogicException" is thrown.
--
|
The risky tests seem to be caused by v4.4.0. |
5 tasks
I sent PR to fix: codeigniter4/CodeIgniter4#7867 |
5 tasks
CodeIgniter 4.4.1 released, all issues fixed. @kenjis thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
see https://github.com/codeigniter4/shield/actions/runs/5984579479/job/16235976345?pr=801
The text was updated successfully, but these errors were encountered: