Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Environments #9242

Open
okatse opened this issue Oct 28, 2024 · 2 comments
Open

Adding Environments #9242

okatse opened this issue Oct 28, 2024 · 2 comments
Labels
missing feature Reported issue which is not a bug but needs to be implemented

Comments

@okatse
Copy link

okatse commented Oct 28, 2024

class ExceptionHandler Line 78

            if (! str_contains($request->getHeaderLine('accept'), 'text/html')) {
                $data = (ENVIRONMENT === 'development' || ENVIRONMENT === 'testing')
                    ? $this->collectVars($exception, $statusCode)
                    : '';

If I add a new environment, this piece of code causes data trimming. Could this be modularized ?
Example :

           $som_config = new \Config\App();

            if (! str_contains($request->getHeaderLine('accept'), 'text/html')) {
                $data = (in_array(ENVIRONMENT, $som_config->som_env))
                    ? $this->collectVars($exception, $statusCode)
                    : '';
@michalsn michalsn added the missing feature Reported issue which is not a bug but needs to be implemented label Nov 14, 2024
@kenjis
Copy link
Member

kenjis commented Nov 15, 2024

Why do you need this?

@okatse
Copy link
Author

okatse commented Nov 15, 2024

Clarify. Why do I need to add a new environment ? Modification in the code is required because - the newly created environment does not return errors
Or newly created environment = alweys production

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
missing feature Reported issue which is not a bug but needs to be implemented
Projects
None yet
Development

No branches or pull requests

3 participants