-
-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace _all_ shallow()
test renderings with mount()
#966
Comments
shallow
test renderings with mount
shallow()
test renderings with mount()
Or do |
All except household, which has to be fixed where the error is happening.
I've read the opposite advice; use |
I hear some of that. Can't we add context and routers to our test, though? Here's an article about shallow rendering that seemed to resonate: https://blog.kentcdodds.com/why-i-never-use-shallow-rendering-c08851a68bb7 |
`shallow` to `mount` in steps, removes snapshots, #966
`shallow()` to `mount()` for some tests as much as possible, #966
A little trouble changing ManagedNumberField `shallow` to `mount` #966
Other than the shallow tests not catching bunches of stuff, I think we may find some things not right with our components.
The text was updated successfully, but these errors were encountered: