Remove temporary CSV file #53
Merged
+38
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bjwebb
approved these changes
Aug 7, 2024
tillywoodfield
force-pushed
the
add-logs
branch
from
6ba9a8e to
40e953a
Compare
tillywoodfield
force-pushed
the
fix-missing-activities
branch
from
b554f8c to
199b60e
Compare
Bjwebb
previously approved these changes
Aug 7, 2024
tillywoodfield
force-pushed
the
fix-missing-activities
branch
from
199b60e to
5e3492b
Compare
Bjwebb
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think that this temporary file could be running out of space and causing activities to be missed. I have removed the temporary file and each activity/organisation is broken up and written to the database separately. I expect this change to increase runtimes, but hopefully not by too much.
See: #52