Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi currency export - choices / parameters (for csv files) #372

Open
stevieflow opened this issue Sep 21, 2022 · 3 comments
Open

Multi currency export - choices / parameters (for csv files) #372

stevieflow opened this issue Sep 21, 2022 · 3 comments
Assignees
Labels
enhancement for-odsc Issues for Open Data Services to work on

Comments

@stevieflow
Copy link

stevieflow commented Sep 21, 2022

Following on from #335 it would be good to detail what we expect when we have multiple currencies in storage

On the CSV output we can request:

one activity per-row

  • default-currency
  • currency
  • total-Commitment
  • total-Disbursement
  • total-Expenditure
  • total-Incoming Funds
  • total-Interest Repayment
  • total-Loan Repayment
  • total-Reimbursement

one transaction per-row

  • default-currency
  • transaction-value
  • transaction_value_currency

one budget per-row

As we store more currencies (starting with USD) via #335 - are we thinking these would be bundled in the csv files as extra columns (in which case, we should be clear on the naming of them), and/or could/should this be something the user could request in the query, and therefore only receive that currency (which will need some clearer specification)

I assume the same would apply for xlsx files

Over to @markbrough initially

@markbrough
Copy link
Member

So I think we should add the following columns:

one activity per-row

  • total-Commitment-USD
  • total-Disbursement-USD
  • total-Expenditure-USD
  • total-Incoming Funds-USD
  • total-Interest Repayment-USD
  • total-Loan Repayment-USD
  • total-Reimbursement-USD
  • total-Commitment-EUR
  • total-Disbursement-EUR
  • total-Expenditure-EUR
  • total-Incoming Funds-EUR
  • total-Interest Repayment-EUR
  • total-Loan Repayment-EUR
  • total-Reimbursement-EUR

one transaction per-row

  • transaction-value-USD
  • transaction-value-EUR

one budget per-row

  • budget-value-USD
  • budget-value-EUR

And while we are here please let's also fix #371

I like the idea of being able to request the returned currency, so that you don't get all these additional columns, but think it might be simple to just do this for now? Wdyt @stevieflow / @radix0000 / others?

@stevieflow
Copy link
Author

Thanks @markbrough

should add

Yes, I think building the template to include all the existing and new columns would be useful regardless. We can then look into any functionality to filter / limit the output

@radix0000 over to you!

@radix0000
Copy link
Collaborator

Okay, will take a look at adding those csv columns.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement for-odsc Issues for Open Data Services to work on
Projects
None yet
Development

No branches or pull requests

3 participants