Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Girocode / PayloadGenerator, BIC validation errors when not passed in to Girocode constructor, with SCT version set to 2 #582

Open
Mies75 opened this issue Oct 10, 2024 · 0 comments

Comments

@Mies75
Copy link

Mies75 commented Oct 10, 2024

Type of issue

[x] Bug
[ ] Question (e.g. about handling/usage)
[ ] Request for new feature/improvement

Expected Behavior

A new instance of Girocode should not throw a nullrefexception or return validation errors when BIC is not supplied and SCT version is set to Girocode.GirocodeVersion.Version2.

Current Behavior

BIC is validated regardless of Girocode.GirocodeVersion. When not supplied a null ref occurs on
_iban = iban.Replace(" ", "").ToUpper();

Possible Solution (optional)

Always validate BIC when Girocode.GirocodeVersion.Version1.
Only validate BIC when Girocode.GirocodeVersion.Version2 and BIC is supplied.

Steps to Reproduce (for bugs)

var payload = new Girocode(iban:"NL86INGB0002445588", bic: null, name: "a name", remittanceInformation: "some info", amount: 1337.99m, version: Girocode.GirocodeVersion.Version2, encoding: Girocode.GirocodeEncoding.UTF_8);

Your Environment

  • Version used: 1.6.0
  • Compiled from source or NuGet package?: NuGet package
  • Payload/Encoded text: see example
  • Used payload generator: Girocode
  • Used ECC-level: 15
  • Used renderer class: Base64QRCode
  • Environment (.NET 3.5, .NET 4.X, .NETCore, ...): NET8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants
@Mies75 and others