Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Improvement: UI for job list items with undisclosed salary can be improved #397

Closed
2 tasks done
EbrahimAfridi opened this issue Sep 23, 2024 · 5 comments
Closed
2 tasks done

Comments

@EbrahimAfridi
Copy link

πŸ“œ Description

The current UI for the job list items is not good for the text "not disclosed" The text should appear in a single row and not wrap around to the next line.

Screenshot 2024-09-23 at 1 09 40β€―PM

πŸ‘Ÿ Reproduction steps

  1. Goto the home screen and scroll down to the job listing
  2. See the job listing with undisclosed salary

πŸ‘ Expected behavior

The text "Not Disclosed" should appear in a single row and not wrap around to the next line.

πŸ“ƒ Provide any additional context for the Bug.

No response

πŸ‘€ Have you spent some time to check if this bug has been raised before?

  • I checked and didn't find similar issue

🏒 Have you read the Contributing Guidelines?

@EbrahimAfridi
Copy link
Author

Assign me this issue.

@poswalsameer
Copy link
Contributor

poswalsameer commented Oct 3, 2024

Hi @EbrahimAfridi, there's already a PR #377 merged with this same issue. You can have a look at it. Thanks!

@divu777
Copy link

divu777 commented Oct 17, 2024

Saw the PR , i think it still does show the "NOT DISCLOSED" , i will say just find a better way to display like use "β€”" or "N/A." instead of "NOT DISCLOSED" just change the line and push the same PR no ned to raise another one just for one liner thing.

image_2024-10-17_055545099

@poswalsameer
Copy link
Contributor

Saw the PR , i think it still does show the "NOT DISCLOSED" , i will say just find a better way to display like use "β€”" or "N/A." instead of "NOT DISCLOSED" just change the line and push the same PR no ned to raise another one just for one liner thing.

image_2024-10-17_055545099

Nice idea, I will discuss this with the members of this repository, and if they allow, I will surely do that.

@VineeTagarwaL-code
Copy link
Collaborator

opening a new issue for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants