Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: search is not working properly in landing page. #687

Open
lokeshpabboji opened this issue Oct 10, 2024 · 4 comments · May be fixed by #688 or #704
Open

bug: search is not working properly in landing page. #687

lokeshpabboji opened this issue Oct 10, 2024 · 4 comments · May be fixed by #688 or #704
Assignees
@lokeshpabboji
Labels
bug Something isn't working needs-triage

Comments

@lokeshpabboji
Copy link

Describe the bug
when we search in the website it's only searching for problemTitle and not TrackTitles.

Expected behavior
It will be nice to see the results related to TrackTitle also. It's a small issue but pretty annoying when we search for a track using TrackTitle.
@lokeshpabboji lokeshpabboji added bug Something isn't working needs-triage labels Oct 10, 2024
@lokeshpabboji
Copy link
Author

please assign this to me.

@lokeshpabboji lokeshpabboji linked a pull request Oct 10, 2024 that will close this issue
Open
@lokeshpabboji
Copy link
Author

lokeshpabboji commented Oct 11, 2024 •
edited
Loading

Pull request #688 done ✅

@anmolBan
Copy link

Please correct me if I am wrong, but only this much code is needed to fix the search.
Screenshot 2024-10-20 125619

By the way this is the very first time I am trying to make an open source contribution.

@lokeshpabboji
Copy link
Author

lokeshpabboji commented Nov 20, 2024 •
edited
Loading

you can see in my pull request that where did i change the code to fix this issue

devin-ai-integration bot added a commit that referenced this issue Dec 11, 2024
@devin-ai-integration @hkirat
fix: include track titles in search results
adf35c5 
- Added trackTitle to Fuse.js search keys
- Fixes #687

Co-Authored-By: Harkirat Singh <[email protected]>
@devin-ai-integration devin-ai-integration bot linked a pull request Dec 11, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lokeshpabboji lokeshpabboji

Labels
bug Something isn't working needs-triage
Projects
None yet
Milestone
No milestone
2 participants
@anmolBan @lokeshpabboji