Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Save Caption Settings Between Video Plays #1493

Closed
nitesh2920 opened this issue Oct 20, 2024 · 5 comments · Fixed by #1503
Closed

feature: Save Caption Settings Between Video Plays #1493

nitesh2920 opened this issue Oct 20, 2024 · 5 comments · Fixed by #1503
Assignees
Labels
enhancement New feature or request

Comments

@nitesh2920
Copy link

Is your feature request related to a problem? Please describe.
I'm always frustrated when I have to manually adjust my caption settings every time I play a video.
It would be much easier if my preferences were saved, as I often prefer captions to be enabled.

Describe the solution you'd like
I would like the application to save my caption settings using local storage or cookies so that when I play a video, my preference caption setting is automatically applied without doinng manually.

Describe alternatives you've considered
It can be implement using cookies also , but local storage is easy and more starighforward .

Additional context
Add any other context or screenshots about the feature request here.

@nitesh2920 nitesh2920 added the enhancement New feature or request label Oct 20, 2024
@IkramBagban
Copy link
Contributor

would love to work on it.
/assign

@IkramBagban
Copy link
Contributor

Thanks

@IkramBagban
Copy link
Contributor

PR is Done #1503

@nitesh2920
Copy link
Author

nitesh2920 commented Oct 23, 2024

@IkramBagban does it include all the styles of subtitles what user set one time will be persistent across all other videos like fontsize , caption background?

@IkramBagban
Copy link
Contributor

@IkramBagban does it include all the styles of subtitles what user set one time will be persistent across all other videos like fontsize , caption background?

I haven't tested that

devsargam pushed a commit that referenced this issue Dec 3, 2024
…1493) (#1503)

* feat: persist caption settings in localStorage on track mode change (#1493)

* refactor: combine both the with same dependancy
hkirat pushed a commit that referenced this issue Dec 5, 2024
…1493) (#1503)

* feat: persist caption settings in localStorage on track mode change (#1493)

* refactor: combine both the with same dependancy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants