Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video reloads when we click on quality button even if the quality is same #142

Closed
Dushyantbha012 opened this issue Mar 3, 2024 · 6 comments
Labels

Comments

@Dushyantbha012
Copy link

Dushyantbha012 commented Mar 3, 2024

Screencast from 03-03-24 11:31:28 AM IST.webm
When you are watching videos say on 1080p on the website and in the quality list if we select 1080p it reloads, but it should not.
Please assign this issue to me, i am part of your 0-100 cohort2; i have found the files from where this issue can be solved.

@hkirat
Copy link
Contributor

hkirat commented Mar 12, 2024

Whoever is solving this please attach the video selectors to the video player and remove the buttons we have created on the side

@hkirat hkirat added the $50 label Mar 12, 2024
@aadeshkulkarni
Copy link

aadeshkulkarni commented Mar 12, 2024

Whoever is solving this please attach the video selectors to the video player and remove the buttons we have created on the side

@hkirat - 2 clarifying questions on this:

  1. did you mean these quality control buttons should be removed ? HD - (1080p, 480p & 360p)

Screenshot 2024-03-12 at 1 32 05 PM

  1. attach the video selectors to the video player - Does that mean auto-selecting the video quality based on the user's screen viewport ?

@adarsh-mamgain
Copy link

adarsh-mamgain commented Mar 12, 2024

Hey @hkirat, as per my understanding do you mean -

  1. Delete the QualitySelector and QualitySelectorControllBar
  2. Appending the video selectors to video player using some package like @silvermine/videojs-quality-selector
  3. Then provide video quality source:

Either using <source>

<video id="video_1" class="video-js vjs-default-skin" controls preload="auto" width="640" height="268">
   <source src="https://example.com/video_720.mp4" type="video/mp4" label="720P">
   <source src="https://example.com/video_480.mp4" type="video/mp4" label="480P" selected="true">
   <source src="https://example.com/video_360.mp4" type="video/mp4" label="360P">
</video>

Or using player.src()

player.src([
   {
      src: 'https://example.com/video_720.mp4',
      type: 'video/mp4',
      label: '720P',
   },
   {
      src: 'https://example.com/video_480.mp4',
      type: 'video/mp4',
      label: '480P',
      selected: true,
   },
   {
      src: 'https://example.com/video_360.mp4',
      type: 'video/mp4',
      label: '360P',
   },
]);

If the idea is correct, could you please assign the task. If not, please clarify.

@Deepak1649
Copy link
Contributor

Hey, can you assign this issue to me.

@nimit9
Copy link
Contributor

nimit9 commented Mar 21, 2024

Hey, can you assign this issue to me.

It's already resolved by #220

@Nitin6404
Copy link

Why this issue isn't close ? and also labelled with bounty. If there any job left here, plz provide context So ppl can resolve it or else maintainers can close it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants