Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui: sometimes SQL fails to highlight #26826

Closed
couchand opened this issue Jun 19, 2018 · 4 comments
Closed

ui: sometimes SQL fails to highlight #26826

couchand opened this issue Jun 19, 2018 · 4 comments
Labels
A-webui-layout-and-style C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. no-issue-activity X-stale

Comments

@couchand
Copy link
Contributor

The library we're using to highlight SQL (highlight.js) sometimes fails to recognize SQL, so the highlighting doesn't work.

Extracted from #26711 (comment)

image

Small bug: certain fingerprints don't syntax highlight when I go to them. Can't tell what the pattern is.
@couchand couchand added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. A-webui-layout-and-style labels Jun 19, 2018
@couchand couchand mentioned this issue Jun 19, 2018
Merged
@vilterp
Copy link
Contributor

vilterp commented Jun 19, 2018

So it's being invoked, but fails to recognize SELECT, FROM, WHERE, and AND as SQL keywords? Jeez…

@couchand
Copy link
Contributor Author

I think the language detection is getting screwed up somehow, maybe by the underscores?

@vilterp
Copy link
Contributor

vilterp commented Oct 10, 2018

Consider doing this on the server size while formatting via maddyblue/sqlfmt#38

@github-actions
Copy link

github-actions bot commented Jun 6, 2021

We have marked this issue as stale because it has been inactive for
18 months. If this issue is still relevant, removing the stale label
or adding a comment will keep it active. Otherwise, we'll close it in
5 days to keep the issue queue tidy. Thank you for your contribution
to CockroachDB!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-webui-layout-and-style C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. no-issue-activity X-stale
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vilterp @couchand