Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

follow-up: systemd: open path in terminal improvements #21281

Closed
garrett opened this issue Nov 18, 2024 · 2 comments · Fixed by #21284
Closed

follow-up: systemd: open path in terminal improvements #21281

garrett opened this issue Nov 18, 2024 · 2 comments · Fixed by #21284
Assignees
Labels
followup Set when merging a PR on the condition that future work is done. Clear when work is complete.

Comments

@garrett
Copy link
Member

garrett commented Nov 18, 2024

I noticed a few issue from the screenshots that should be handled in a follow-up:

image

  • Have the error in the title instead of "error": "Directory does not exist"

image

  • Text needs to be reworked. Title: "Running process prevents directory change", Body: "Changing the directory will forcefully stop the currently running process." We might want to add a hint that this could be interactive by tacking on an extra sentence, with something like: "The process can also be stopped manually in the terminal before continuing."
  • Action buttons should say what they will do. "Continue" isn't the action that's being performed; it's "Change directory".
  • If this is a dangerous action, as the alert state indicates, then the button should reflect that; it shouldn't be a secondary button, but a danger button.

Originally posted by @garrett in #21162 (comment)

@garrett garrett added followup Set when merging a PR on the condition that future work is done. Clear when work is complete. release-blocker Targetted for next release and removed release-blocker Targetted for next release labels Nov 18, 2024
@ashley-cui
Copy link
Contributor

@garrett For the directory does not exist warning, should the title include "Unable to open directory" or something like that, since the error itself is the inability to open the directory, and the reason is that it doesn't exist, or should the title be "Directory does not exist" If so, what should the description be? It seems like having a title of "Directory does not exist" and then "/asdf does not exist" would also be repetitive

@garrett
Copy link
Member Author

garrett commented Nov 18, 2024

@ashley-cui: Sure! You're right. That sounds good.

"Unable to open directory"
"/asdf does not exist."

Works for me! 👍

I'm guessing permissions would be an even more likely issue than a directory not being able to be opened, as (at least for now) Cockpit Files would already have to see that the directory exists to be able to request the Terminal to open it. I could imagine that the directory does not have +x permission for access, but can still be seen from Cockpit Files.

So, something like this could work in that case:

"Permission denied"
"Cannot open /asdf. Permissions block access to this directory."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
followup Set when merging a PR on the condition that future work is done. Clear when work is complete.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants