From 9c19728795958bc030039c88387fb90b1d372bf0 Mon Sep 17 00:00:00 2001
From: Marius Vollmer <marius.vollmer@gmail.com>
Date: Wed, 11 Dec 2024 20:54:14 +0200
Subject: [PATCH] shell: Fix bugs found by TypeScript

The cockpit.spawn function takes only two arguments (unlike
cockpit.script).

Location.reload() doesn't take any arguments, the "force_reload"
argument is a Firefox extension.

There is no "this.onSelect" in CockpitNav.
---
 pkg/shell/nav.tsx          | 2 +-
 pkg/shell/shell-modals.tsx | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/pkg/shell/nav.tsx b/pkg/shell/nav.tsx
index 571e1fdf9ad3..2e102d21d39d 100644
--- a/pkg/shell/nav.tsx
+++ b/pkg/shell/nav.tsx
@@ -197,7 +197,7 @@ export class CockpitNav extends React.Component {
         return (
             <>
                 <SearchInput placeholder={_("Search")} value={this.state.search} onChange={(_, search) => this.setState({ search })} onClear={() => this.setState({ search: "" })} className="search" />
-                <Nav onSelect={this.onSelect} theme="dark">
+                <Nav theme="dark">
                     { groups.map(g =>
                         <section className="pf-v5-c-nav__section" aria-labelledby={"section-title-" + g.name} key={g.name}>
                             <div className="nav-group-heading">
diff --git a/pkg/shell/shell-modals.tsx b/pkg/shell/shell-modals.tsx
index 19560cc2d2be..3559a8e5b82b 100644
--- a/pkg/shell/shell-modals.tsx
+++ b/pkg/shell/shell-modals.tsx
@@ -45,7 +45,7 @@ export const AboutCockpitModal = ({ dialogResult }) => {
     useInit(() => {
         const packages = [];
         const cmd = "(set +e; rpm -qa --qf '%{NAME} %{VERSION}\\n'; dpkg-query -f '${Package} ${Version}\n' --show; pacman -Q) 2> /dev/null | grep cockpit | sort";
-        cockpit.spawn(["bash", "-c", cmd], [], { err: "message" })
+        cockpit.spawn(["bash", "-c", cmd], { err: "message" })
                 .then(pkgs =>
                     pkgs.trim().split("\n")
                             .forEach(p => {
@@ -103,7 +103,7 @@ export const LangModal = ({ dialogResult }) => {
         const cookie = "CockpitLang=" + encodeURIComponent(selected) + "; path=/; expires=Sun, 16 Jul 3567 06:23:41 GMT";
         document.cookie = cookie;
         window.localStorage.setItem("cockpit.lang", selected);
-        window.location.reload(true);
+        window.location.reload();
     }
 
     const manifest = import_ShellManifest(cockpit.manifests.shell || { });