Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues on poor network and poor Modbus controllers #57

Open
AkLim94 opened this issue Nov 12, 2022 · 2 comments
Open

Fix issues on poor network and poor Modbus controllers #57

AkLim94 opened this issue Nov 12, 2022 · 2 comments

Comments

@AkLim94
Copy link

AkLim94 commented Nov 12, 2022

Dear community,

I experienced some issues when using this excellent component.
The issues appended especially on poor network quality and probably poor controllers (with strange behaviors).
I made some changes in the code to fix these issues and would like to share with you, but unfortunately how to contribute....
If anyone know how to do, it's welcome

The changes made:

  • Check MBAP header with the length received
  • Added more events (to be able to display Modbus frames)
  • Clear input buffer before to send command (to be sure what we receive is for the command we've just sent and not for the previous command, yes some controllers response several times the same)

Regards

@plpolak
Copy link
Member

plpolak commented Oct 28, 2024

If you want to have your changes merged, please attach the changes to this ticket, so I can review them for merge.

@AkLim94
Copy link
Author

AkLim94 commented Oct 28, 2024

IdModbusClient.zip
Hi, I attached my customized unit.
Please search for // Lim
I'm so sorry some comments are in French :)

Best regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants