New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

General refactor #106

Open

matt-dray opened this issue Nov 9, 2023 · 0 comments

Labels

documentation should

Milestone

Collaborator

matt-dray commented Nov 9, 2023 •

edited

Loading

'Simple' changes:

Reorganise scripts in R/ for clarity (inc simplify utils)
Simplify functions (there probably only needs to be one .get_start_row_*() function with an argument to specify which pre-table information you're trying to insert)
Rename suspect variables (table, content?)
De-nest where possible (break into intermediate variables)
Include more @noRd function docs
Sprinkle some more explanatory 'why' comments

Requires more thought/effort:

Would it be easier to handle pre-table content if the text of each row were put into a vector? Could then just check the length of that vector and insert the table at length(x) + 1, for example. At the moment there's repetitive checks for 'if blanks message was supplied, then ...', 'if source was supplied, then...'.
Drop-in replace {openxlsx2} for {openxlsx} (?) as per Change back-end to use {openxlsx2} #70

Probably more.

The text was updated successfully, but these errors were encountered:

matt-dray added documentation code labels

matt-dray removed the code label

matt-dray added this to the Backlog milestone

matt-dray added the should label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment