make compatible with python3 #53
Conversation
…side of pyne.mesh.
…in the iter_ve method.
…e.mesh tag interface.
…another mesh type when it isn't completely necessary.
|
CI needs to also be updated to test with python 3 and pymoab. |
|
I’m a little concerned that commit ae30824 was a merge commit instead of a rebase, for when it comes time to combine this with the main PR? |
|
I also think we need a tutorial on utf-8 and encodings |
|
I agree on the utf-8 tutorial.. I am not on board even with some of my own changes here. I just am not sure the better way to do some of this. |
| except: | ||
| from itertools import zip_longest | ||
|
|
||
| from itertools import zip_longest |
There was a problem hiding this comment.
note to self: this line should be removed
| @@ -397,7 +397,11 @@ def write_partisn_input_1D(): | |||
| ngroup = 5 | |||
|
|
|||
| # expected output file | |||
| file_expected = THIS_DIR + '/files_test_partisn/partisn_1D_expected.inp' | |||
| import platform | |||
| if platform.python_version().split('.')[0] == '2': | |||
There was a problem hiding this comment.
all these expected files that have a python 2 and python 3 version may not actually be necessary in the end. I need to check if the changes I made for python3 do the same thing in python 2 before I delete the original files (which are the python 2 version). Thanks to dictionaries no longer being ordered, things were being printed in different orders.
| try: | ||
| from itertools import izip as zip | ||
| except: | ||
| pass |
|
I have issued a PR against @kkiesling branch that should fix all the python2 problem raised by this... while keeping the tests working on |
gonuke
force-pushed
the
pymoab_cleanup
branch
from
e7de8fe to
70efe88
Compare
|
This PR being deferred until after PyMOAB is in PyNE. Will follow up with smaller PRs into pyne/pyne. |
(creating PR to to be able to run on CI, changes likely still needed)
This work is attempting to make all things compatible with python3. Changes made here need to be checked that they are still compatible with python2.
There are known python3 errors in the following files but I am unsure how to fix them:
test_alara.py- rounding error in one of the files generatedtest_mcnp.py- rounding errorThis PR addresses #49 .