From 70cf69cb7fd147d81c79fc1e3dcd2ac652c6e99e Mon Sep 17 00:00:00 2001 From: Paul Wilson Date: Fri, 15 Feb 2019 17:39:22 -0600 Subject: [PATCH] Apply suggestions from initial code review by @katyhuff Thanks for this quick review @katyhuff Co-Authored-By: gonuke --- CMakeLists.txt | 2 +- docker/make_pyne_docker_image.py | 9 ++++----- pyne/r2s.py | 1 - 3 files changed, 5 insertions(+), 7 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 85bc77676e..c663745d47 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -72,7 +72,7 @@ MESSAGE("-- HDF5 Library directories: ${HDF5_LIBRARY_DIRS}") MESSAGE("-- HDF5 Libraries: ${HDF5_C_LIBRARIES}") -# Look for MOAB is requested +# Look for MOAB if requested if(WITH_MOAB) # user may have set a search path if(NOT MOAB_ROOT) diff --git a/docker/make_pyne_docker_image.py b/docker/make_pyne_docker_image.py index e7fb0af79a..2f8b9e9e70 100755 --- a/docker/make_pyne_docker_image.py +++ b/docker/make_pyne_docker_image.py @@ -51,7 +51,7 @@ def build_name(args): def build_docker(args): """Forms the docker command line and executes it. IF the push flag is provided also pushes it to DockerHub which requires PyNE admin right on - DockerHub(Docker login is assumed(... + DockerHub(Docker login is assumed...) Parameters ---------- @@ -90,9 +90,8 @@ def build_docker(args): def main(): """Parse the different arguments and call the proper methods. - """ - description = "Build a docker image for PyNE" + description = 'Build a docker image for PyNE' parser = ap.ArgumentParser(description=description) py_version = 'Require a specific python version' @@ -118,10 +117,10 @@ def main(): parser.add_argument('--deps', help=deps, action='store_true', default=False) - name = "Set docker imgae name" + name = 'Set docker image name' parser.add_argument('--name', help=name, default='') - push = 'Push docker imgae on dockerhub' + push = 'Push docker image on dockerhub' parser.add_argument('--push', '-p', '-push', help=push, action='store_true', default=False) diff --git a/pyne/r2s.py b/pyne/r2s.py index 292815dd79..267bfc0d94 100644 --- a/pyne/r2s.py +++ b/pyne/r2s.py @@ -12,7 +12,6 @@ def resolve_mesh(mesh_reference, tally_num = None, flux_tag = "n_flux", output_material=False): - """This function creates a method that will consume many mesh-like objects (e.g. mesh, an h5m file, a meshtal file, etc) and returns a robust PyNE mesh object accordingly.