Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edge start end geometry configuration new feature #65

Open
cneben opened this issue Sep 16, 2018 · 2 comments
Open

Edge start end geometry configuration new feature #65

cneben opened this issue Sep 16, 2018 · 2 comments
Assignees
@cneben
Labels
enhancement

Comments

@cneben
Copy link
Owner

cneben commented Sep 16, 2018

First issues/todos with recent edge start/end geometry configuration:

  • Edge items are invisible until host node is moved (missing an initial call to updateItem() ?).
  • Round items are not working when src and dst are both Qan.EdgeItem.Cirlce/Qan.EdgeItem.CircleOpen

image
@cneben cneben self-assigned this Sep 16, 2018
cneben added a commit that referenced this issue Sep 18, 2018
@cneben
WIP rename srcType and dstType to srcShape / dstShape (more explicit!)
7be2b2e 
#65

Signed-off-by: cneben <[email protected]>
cneben added a commit that referenced this issue Sep 18, 2018
@cneben
WIP Fix p1/p2 correction when there is no src/dst shape.
1f01cd4 
(And introduce a bug!)

#65

Signed-off-by: cneben <[email protected]>
cneben added a commit that referenced this issue Sep 18, 2018
@cneben
WIP Fix a typo in Qan.EdgeTemplate src shape circle.
4cf8b9c 
#65

Signed-off-by: cneben <[email protected]>
cneben added a commit that referenced this issue Sep 18, 2018
@cneben
WIP. Add src/dst shape configuration in curved.qml test.
ee6529e 
TODO: Add full binding from EdgeStyle to EdgeItem for both shapeLength
and srcShape/dstShape...
#65

Signed-off-by: cneben <[email protected]>
cneben added a commit that referenced this issue Sep 19, 2018
@cneben
Add full binding between qan::EdgeStyle and qan::EdgeItem for srcShap…
30f5d52 
…e, dstShape and arrowSize properties.

Bind lineWidth property open arrow, open circle and open rect EdgeTemplate delegates shapes.
Cosmetic fixes.
#65

Signed-off-by: cneben <[email protected]>
@cneben
Copy link
Owner Author

cneben commented Sep 19, 2018

image

cneben added a commit that referenced this issue Sep 19, 2018
@cneben
Add new edge src/dst shape test for ports.
b974a2b 
#65

Signed-off-by: cneben <[email protected]>
@Letrab
Copy link
Contributor

Letrab commented Oct 1, 2018

Thank you very much on your further work on this!

I noticed a strange behaviour still, in the current example (I looked myself already, but cannot pinpoint the problem exactly):

Open the test-edges example

  1. Select Dst shape as Open Circle
  2. Increase arrow size to 7 (+++)
  3. Select Dst shape as Circle --> No circle shown?!?
  4. Decrease arrow size to 5 (--) (Circle shown again!)
  5. Select Dst shape as Open Circle
  6. Increase arrow size to 7 (+++)
  7. Select Dst shape as Circle --> Circle shown (smaller, still size 5) in Open Circle!?!

It has something to do with updating the points according to the size. But I added some tracing, and everything seemed fine to me... What I find mostly strange is that in step 7 two shapes are shown, which on QML side, is very strange (as the visible statement is exclusive).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cneben cneben

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cneben @Letrab