Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

self-assessment: add Lima #1264

Merged
merged 1 commit into from
Nov 8, 2024
Merged

Conversation

AkihiroSuda
Copy link
Contributor

Add self-assessment of Lima (CNCF Sandbox)

cc @jandubois @afbjorklund @balajiv113

Copy link

netlify bot commented Jun 3, 2024

Deploy Preview for tag-security ready!

Name Link
🔨 Latest commit 07c348d
🔍 Latest deploy log https://app.netlify.com/sites/tag-security/deploys/672d5c1308929900084f2598
😎 Deploy Preview https://deploy-preview-1264--tag-security.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@JustinCappos
Copy link
Collaborator

A few issues with the checks + being out of date with the base branch. Seems fine to merge after.

@AkihiroSuda AkihiroSuda force-pushed the lima-self-assessment branch 4 times, most recently from ba003a9 to 867136c Compare November 8, 2024 00:13
@AkihiroSuda
Copy link
Contributor Author

Why is this failing?
https://github.com/cncf/tag-security/actions/runs/11733542958/job/32688010333?pr=1264

FILE: community/assessments/projects/lima/self-assessment.md
make: *** [Makefile:25: links] Error 1

Add self-assessment of [Lima](https://lima-vm.io) (CNCF Sandbox)

Signed-off-by: Akihiro Suda <[email protected]>
@AkihiroSuda
Copy link
Contributor Author

AkihiroSuda commented Nov 8, 2024

The links work for me

$ npx markdown-link-check --verbose ./community/assessments/projects/lima/self-assessment.md 

FILE: ./community/assessments/projects/lima/self-assessment.md
  [✓] #metadata → Status: 200
  [✓] #security-links → Status: 200
  [✓] #overview → Status: 200
  [✓] #actors → Status: 200
  [✓] #actions → Status: 200
  [✓] #background → Status: 200
  [✓] #goals → Status: 200
  [✓] #non-goals → Status: 200
  [✓] #self-assessment-use → Status: 200
  [✓] #security-functions-and-features → Status: 200
  [✓] #project-compliance → Status: 200
  [✓] #secure-development-practices → Status: 200
  [✓] #security-issue-resolution → Status: 200
  [✓] #appendix → Status: 200
  [✓] https://github.com/lima-vm/lima → Status: 200
  [✓] https://github.com/lima-vm/.github/blob/main/SECURITY.md → Status: 200
  [✓] https://github.com/lima-vm/lima/blob/master/templates/default.yaml → Status: 200
  [✓] https://lima-vm.io/ → Status: 200
  [✓] https://containerd.io → Status: 200
  [✓] https://github.com/containerd/nerdctl → Status: 200
  [✓] https://github.com/lima-vm/lima/tree/master/templates → Status: 200
  [✓] https://github.com/lima-vm/socket_vmnet → Status: 200
  [✓] https://lima-vm.io/docs/community/contributing/ → Status: 200
  [✓] https://github.com/lima-vm/lima/blob/master/.github/dependabot.yml → Status: 200
  [✓] https://pkg.go.dev/golang.org/x/vuln/cmd/govulncheck → Status: 200
  [✓] https://github.com/lima-vm/lima/security → Status: 200
  [✓] https://lima-vm.io/docs/community/ → Status: 200
  [✓] https://rancherdesktop.io/ → Status: 200
  [✓] https://github.com/abiosoft/colima → Status: 200
  [✓] https://github.com/runfinch/finch → Status: 200
  [✓] https://podman-desktop.io/ → Status: 200
  [✓] https://github.com/lima-vm/lima/security/advisories/new → Status: 200
  [✓] https://github.com/lima-vm/lima/security/advisories → Status: 200
  [✓] https://github.com/lima-vm/lima/security/advisories/GHSA-f7qw-jj9c-rpq9 → Status: 200
  [✓] https://www.bestpractices.dev/en/projects/6505 → Status: 200
  [✓] https://github.com/unixorn/lima-xbar-plugin → Status: 200
  [✓] https://github.com/afbjorklund/lima-gui → Status: 200

  37 links checked.

@brandtkeller
Copy link
Collaborator

Hey @AkihiroSuda - thanks for calling this out. It appears there is an issue with the linting checks that should be fixed in #1403 .

Nonetheless I checked your PR locally and agree that it is indeed passing that check when the check is functionality as intended.

@brandtkeller brandtkeller merged commit 3a0d6f0 into cncf:main Nov 8, 2024
9 of 10 checks passed

|||
| -- | -- |
| Assessment Stage | Incomplete |
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could I mark this as Completed?
What is the criteria?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants