Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved calculation of CRC32 #46936

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

Dr15Jones
Copy link
Contributor

PR description:

  • made code a simple function
  • switched to taking a std::string_view to avoid unnecessary allocations
  • renamed function and file name to match

PR validation:

Unit tests pass.

- made code a simple function
- switched to taking a std::string_view to avoid unnecessary allocations
- renamed function and file name to match
@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 13, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46936/43008

  • There are other open Pull requests which might conflict with changes you have proposed:

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones for master.

It involves the following packages:

  • DataFormats/Provenance (core)
  • EventFilter/L1TRawToDigi (l1)
  • FWCore/Utilities (core)

@Dr15Jones, @aloeliger, @epalencia, @makortel, @smuzaffar can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @dinyar, @eyigitba, @felicepantaleo, @makortel, @missirol, @mmusich, @rovere, @thomreis, @wddgit this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 36KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c356ef/43442/summary.html
COMMIT: d8046a1
CMSSW: CMSSW_15_0_X_2024-12-13-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46936/43442/install.sh to create a dev area with all the needed externals and cmssw changes.

  • DAS Queries: The DAS query tests failed, see the summary page for details.

Comparison Summary

Summary:

@makortel
Copy link
Contributor

Comparison differences are related to #46416 and #39803

@makortel
Copy link
Contributor

+core

@aloeliger
Copy link
Contributor

+l1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants