-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved calculation of CRC32 #46936
base: master
Are you sure you want to change the base?
Conversation
- made code a simple function - switched to taking a std::string_view to avoid unnecessary allocations - renamed function and file name to match
please test |
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46936/43008
|
A new Pull Request was created by @Dr15Jones for master. It involves the following packages:
@Dr15Jones, @aloeliger, @epalencia, @makortel, @smuzaffar can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+1 Size: This PR adds an extra 36KB to repository
Comparison SummarySummary:
|
+core |
+l1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2) |
PR description:
PR validation:
Unit tests pass.