-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix DQM config test: Increase number of sequences to process #46923
base: master
Are you sure you want to change the base?
Conversation
please test |
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46923/42985 |
A new Pull Request was created by @iarspider for master. It involves the following packages:
@antoniovagnerini, @rseidita can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+1 Size: This PR adds an extra 16KB to repository
Comparison SummarySummary:
|
hi @iarspider, I was wondering if it wouldn't be better to increase the #DQM sequences to a much larger threshold i.e. 999 to avoid repeating this PR every time the threshold is exceeded by a unit. |
No objection. |
please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46923/42989 |
Pull request #46923 was updated. @antoniovagnerini, @rseidita can you please check and sign again. |
+1 Size: This PR adds an extra 16KB to repository
Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2) |
Looks like DQM sequences to process has increased to 341 that is why TestDQMOfflineConfigurationGotAll unittest is failing in IBS. This PR updates the DQM sequences limit.