Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DQM config test: Increase number of sequences to process #46923

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

iarspider
Copy link
Contributor

Looks like DQM sequences to process has increased to 341 that is why TestDQMOfflineConfigurationGotAll unittest is failing in IBS. This PR updates the DQM sequences limit.

@iarspider
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 12, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @iarspider for master.

It involves the following packages:

  • DQMOffline/Configuration (dqm)

@antoniovagnerini, @rseidita can you please review it and eventually sign? Thanks.
@rociovilar, @threus this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-858ba7/43408/summary.html
COMMIT: 6dbf82d
CMSSW: CMSSW_15_0_X_2024-12-11-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46923/43408/install.sh to create a dev area with all the needed externals and cmssw changes.

  • DAS Queries: The DAS query tests failed, see the summary page for details.

Comparison Summary

Summary:

@antoniovagnerini
Copy link

hi @iarspider, I was wondering if it wouldn't be better to increase the #DQM sequences to a much larger threshold i.e. 999 to avoid repeating this PR every time the threshold is exceeded by a unit.

@iarspider
Copy link
Contributor Author

hi @iarspider, I was wondering if it wouldn't be better to increase the #DQM sequences to a much larger threshold i.e. 999 to avoid repeating this PR every time the threshold is exceeded by a unit.

No objection.

@iarspider
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Pull request #46923 was updated. @antoniovagnerini, @rseidita can you please check and sign again.

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-858ba7/43417/summary.html
COMMIT: 83675c3
CMSSW: CMSSW_15_0_X_2024-12-12-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46923/43417/install.sh to create a dev area with all the needed externals and cmssw changes.

  • DAS Queries: The DAS query tests failed, see the summary page for details.

Comparison Summary

Summary:

@antoniovagnerini
Copy link

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants