Run-dependent pixel simulation using additionally compressed SimHit info #46884
Conversation
|
cms-bot internal usage |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46884/42918
|
|
A new Pull Request was created by @ferencek for master. It involves the following packages:
@AdrianoDee, @Moanwar, @antoniovilela, @civanch, @cmsbuild, @davidlange6, @DickyChant, @fabiocos, @kpedro88, @mandrenguyen, @mdhildreth, @miquork, @rappoccio, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
SimTracker/Common/interface/SiPixelChargeReweightingAlgorithm.h
Outdated
Show resolved
Hide resolved
| } else { | ||
| thePixelThresholdInE = | ||
| CLHEP::RandGaussQ::shoot(engine, theThresholdInE_BPix, theThresholdSmearing_BPix); // gaussian smearing | ||
| } |
There was a problem hiding this comment.
@ferencek , can theoretically a threshold become negative after smearing?
There was a problem hiding this comment.
Note that this is not a feature specific to the newly added code but is appearing in several other places in the code. In theory the threshold could become negative but looking at parameter values in https://github.com/cms-sw/cmssw/blob/CMSSW_14_2_0/SimGeneral/MixingModule/python/SiPixelSimParameters_cfi.py#L65-L73, this would have to be more than a 10-sigma fluctuation. As far as I see, the only implication of such a negative threshold would be that any positive signal or noise would simply pass the threshold which is in principle ok and would not lead to code crashing. Not sure if @carolinecollard has anything to add. So I would say this does not require a fix.
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46884/42946
|
|
Pull request #46884 was updated. @AdrianoDee, @Moanwar, @antoniovilela, @civanch, @cmsbuild, @davidlange6, @DickyChant, @fabiocos, @kpedro88, @mandrenguyen, @mdhildreth, @miquork, @rappoccio, @srimanob, @subirsarkar can you please check and sign again. |
|
Please test |
|
+1 Size: This PR adds an extra 16KB to repository
Comparison SummarySummary:
|
cmsbuild
added
operations-approved
tests-approved
and removed
operations-pending
tests-started
labels
PR description:
This PR is a continuation of #37823 that introduces additionally compressed SimHit info in the form of the PixelSimHitExtraInfoLite data format. The PR also adds a new runTheMatrix workflow (250202.185) that uses this new data format. With this PR integrated, it will be easier to perform validation and compare performance of different pixel charge reweighting approaches. The most recent presentations on this topic are the following ones:
PR validation:
The code compiles. No changes are expected in the standard runTheMatrix workflows because the late charge reweighting is not used by default.
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Backports will likely be needed but it remains to be seen to how many earlier release cycles. This will depend on the details of the validation procedure.
@carolinecollard