edmNew::DetSetVector and edmNew::DetSet are not fully const-correct

[makortel]

As shown in

cmssw/DQM/SiStripMonitorCluster/src/SiStripMonitorCluster.cc

Lines 764 to 765 in 87f3f24

	edmNew::DetSetVector<SiStripCluster>::const_iterator isearch =
	cluster_detsetvektor->find(detid); // search clusters of detid

cmssw/DQM/SiStripMonitorCluster/src/SiStripMonitorCluster.cc

Line 790 in 87f3f24

edmNew::DetSet<SiStripCluster> cluster_detset = (*isearch);

one can get a non-const edmNew::DetSet<T> by de-referencing an edmNew::DetSetVector<T>::const_iterator.

The problems stem from edmNew::DetSet<T> being a proxy type, i.e. it contains a pointer to the container held by the corresponding edmNew::DetSetVector, and necessary offset there

cmssw/DataFormats/Common/interface/DetSetNew.h

Lines 95 to 98 in 87f3f24

	id_type m_id;
	DataContainer const *m_data;
	int m_offset;
	size_type m_size;

and it providing both const and non-const interface.

One specific problem is that (assuming I understood the behavior of boost::transform_iterator correctly, the

cmssw/DataFormats/Common/interface/DetSetVectorNew.h

Line 186 in 87f3f24

result_type operator()(Item const& item) const { return result_type(*m_v, item, m_update); }

returns a non-const edmNew::DetSet. On the other hand, returning const edmNew::DetSet wouldn't help, because edmNew::DetSet has default copy (and move) constructor/assignment, and therefore one can easily copy a const edmNew::DetSet into a non-const edmNew::DetSet.

On a quick though I think the only certain way out would be to have separate "DetSet" types for the const and non-const access of the edmNew::DetSetVector.

[makortel]

assign core

[cmsbuild]

New categories assigned: core

@Dr15Jones,@makortel,@smuzaffar you have been requested to review this Pull request/Issue and eventually sign? Thanks

[cmsbuild]

cms-bot internal usage

[cmsbuild]

A new Issue was created by @makortel.

@Dr15Jones, @antoniovilela, @makortel, @mandrenguyen, @rappoccio, @sextonkennedy, @smuzaffar can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here